Skip to content

Commit b4f0cb0

Browse files
committed
Fix copilot comments.
- Order the ports following alphabetical order of docker-compose files. - Add verification of version in user creation if passing namespace.
1 parent c4afc9f commit b4f0cb0

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

ci/compose.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ function compose_down_all {
2121
}
2222

2323
function all_weaviate_ports {
24-
echo "8090 8093 8087 8088 8089 8086 8082 8083 8075 8092 8094 8085 8080" # in alphabetic order of appearance in docker-compose files
24+
echo "8090 8093 8087 8088 8089 8086 8094 8082 8083 8075 8092 8085 8080" # in alphabetic order of appearance in docker-compose files
2525
}
2626

2727
function wait(){

weaviate/users/base.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -378,6 +378,7 @@ def resp(res: Response) -> str:
378378

379379
body: Dict[str, Any] = {}
380380
if namespace is not None:
381+
self._connection._weaviate_version.check_is_at_least_1_38_0("users.db.create")
381382
body["namespace"] = namespace
382383

383384
return executor.execute(

weaviate/util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ def _capitalize_first_letter(string: str) -> str:
436436
437437
For namespaced collection names of the form ``namespace:CollectionName``,
438438
only the collection portion (after the colon) is capitalized; the namespace
439-
prefix is preserved as-is to keep it lowercase.
439+
prefix is preserved as-is.
440440
441441
Args:
442442
string: The string to be capitalized.

0 commit comments

Comments
 (0)