fix: validate reindex arguments before use (#2098 review)

Validate the tenants argument of update_property_index and
rebuild_property_index as str | List[str] | None before the csv join so
invalid input raises WeaviateInvalidInputError instead of a raw
TypeError, matching the library's _validate_input idiom already applied
to property_name/index_name. Document the WeaviateInvalidInputError in
the affected docstrings and cover the validation with mock tests.

Author: g-despot

mock_tests/test_property_reindex.py

@@ -393,6 +393,21 @@ def test_get_property_indexes(
     weaviate_139_mock.check_assertions()
 
 
+def test_property_reindex_invalid_input(
+    weaviate_139_mock: HTTPServer, client_139: weaviate.WeaviateClient
+) -> None:
+    """Invalid argument types raise WeaviateInvalidInputError before any request is sent."""
+    config = client_139.collections.use(COLLECTION).config
+
+    with pytest.raises(weaviate.exceptions.WeaviateInvalidInputError):
+        config.update_property_index("age", "rangeFilters", tenants=123)  # type: ignore
+    with pytest.raises(weaviate.exceptions.WeaviateInvalidInputError):
+        config.rebuild_property_index("age", "rangeFilters", tenants=[1, 2])  # type: ignore
+    with pytest.raises(weaviate.exceptions.WeaviateInvalidInputError):
+        config.cancel_property_index_task(123, "searchable")  # type: ignore
+    weaviate_139_mock.check_assertions()
+
+
 def test_property_reindex_unsupported_version(
     weaviate_client: weaviate.WeaviateClient,
 ) -> None:

weaviate/collections/config/executor.py

@@ -804,6 +804,7 @@ def update_property_index(
             of the index when `wait_for_completion=True`.
 
         Raises:
+            weaviate.exceptions.WeaviateInvalidInputError: If the input parameters are invalid.
             weaviate.exceptions.WeaviateConnectionError: If the network connection to Weaviate fails.
             weaviate.exceptions.UnexpectedStatusCodeError: If Weaviate reports a non-OK status.
             weaviate.exceptions.ReindexFailedError: If `wait_for_completion=True` and the reindexing task failed.
@@ -814,6 +815,9 @@ def update_property_index(
             [_ValidateArgument(expected=[str], name="property_name", value=property_name)]
         )
         _validate_input([_ValidateArgument(expected=[str], name="index_name", value=index_name)])
+        _validate_input(
+            [_ValidateArgument(expected=[str, List[str], None], name="tenants", value=tenants)]
+        )
 
         path = self.__property_index_path(property_name, index_name)
         body: Dict[str, Any] = {}
@@ -912,6 +916,7 @@ def rebuild_property_index(
             of the index when `wait_for_completion=True`.
 
         Raises:
+            weaviate.exceptions.WeaviateInvalidInputError: If the input parameters are invalid.
             weaviate.exceptions.WeaviateConnectionError: If the network connection to Weaviate fails.
             weaviate.exceptions.UnexpectedStatusCodeError: If Weaviate reports a non-OK status.
             weaviate.exceptions.ReindexFailedError: If `wait_for_completion=True` and the reindexing task failed.
@@ -922,6 +927,9 @@ def rebuild_property_index(
             [_ValidateArgument(expected=[str], name="property_name", value=property_name)]
         )
         _validate_input([_ValidateArgument(expected=[str], name="index_name", value=index_name)])
+        _validate_input(
+            [_ValidateArgument(expected=[str, List[str], None], name="tenants", value=tenants)]
+        )
 
         path = self.__property_index_path(property_name, index_name) + "/rebuild"
         if isinstance(tenants, str):
@@ -991,6 +999,7 @@ def cancel_property_index_task(
             A `PropertyIndexTask` with status `CANCELLED` if a live task was cancelled or `NO_OP` otherwise.
 
         Raises:
+            weaviate.exceptions.WeaviateInvalidInputError: If the input parameters are invalid.
             weaviate.exceptions.WeaviateConnectionError: If the network connection to Weaviate fails.
             weaviate.exceptions.UnexpectedStatusCodeError: If Weaviate reports a non-OK status.
         """