Skip to content

Commit d30b065

Browse files
committed
Revert "Vectors/deprecate legacy introduce named vectors only syntax (#1659)"
This reverts commit f8d7d2d.
1 parent a4c9513 commit d30b065

27 files changed

Lines changed: 604 additions & 2382 deletions

.github/workflows/main.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ concurrency:
2020
env:
2121
WEAVIATE_125: 1.25.34
2222
WEAVIATE_126: 1.26.17
23-
WEAVIATE_127: 1.27.27
24-
WEAVIATE_128: 1.28.16
25-
WEAVIATE_129: 1.29.9
26-
WEAVIATE_130: 1.30.11
23+
WEAVIATE_127: 1.27.14
24+
WEAVIATE_128: 1.28.8
25+
WEAVIATE_129: 1.29.8
26+
WEAVIATE_130: 1.30.9
2727
WEAVIATE_131: 1.31.5
28-
WEAVIATE_132: 1.32.0-rc.1-098c594
28+
WEAVIATE_132: 1.32.0-rc.0-6eb89d6.amd64
2929

3030
jobs:
3131
lint-and-format:

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,4 @@ repos:
4949
language: node
5050
pass_filenames: false
5151
types: [python]
52-
additional_dependencies: [pyright@1.1.400]
52+
additional_dependencies: [pyright@1.1.398]

docs/conf.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import contextlib
77
import os
88
import sys
9+
910
from importlib.metadata import PackageNotFoundError
1011
from importlib.metadata import version as version_func
1112

integration/conftest.py

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
_ReferencePropertyBase,
2929
_ReplicationConfigCreate,
3030
_RerankerProvider,
31-
_VectorConfigCreate,
3231
_VectorIndexConfigCreate,
3332
_VectorizerConfigCreate,
3433
)
@@ -59,9 +58,6 @@ def __call__(
5958
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
6059
description: Optional[str] = None,
6160
reranker_config: Optional[_RerankerProvider] = None,
62-
vector_config: Optional[
63-
Optional[Union[_VectorConfigCreate, List[_VectorConfigCreate]]]
64-
] = None,
6561
) -> Collection[Any, Any]:
6662
"""Typing for fixture."""
6763
...
@@ -133,9 +129,6 @@ def _factory(
133129
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
134130
description: Optional[str] = None,
135131
reranker_config: Optional[_RerankerProvider] = None,
136-
vector_config: Optional[
137-
Optional[Union[_VectorConfigCreate, List[_VectorConfigCreate]]]
138-
] = None,
139132
) -> Collection[Any, Any]:
140133
try:
141134
nonlocal client_fixture, name_fixtures, call_counter # noqa: F824
@@ -155,8 +148,7 @@ def _factory(
155148
collection: Collection[Any, Any] = client_fixture.collections.create(
156149
name=name_fixture,
157150
description=description,
158-
vectorizer_config=vectorizer_config
159-
or (Configure.Vectorizer.none() if vector_config is None else None),
151+
vectorizer_config=vectorizer_config or Configure.Vectorizer.none(),
160152
properties=properties,
161153
references=references,
162154
inverted_index_config=inverted_index_config,
@@ -167,7 +159,6 @@ def _factory(
167159
replication_config=replication_config,
168160
vector_index_config=vector_index_config,
169161
reranker_config=reranker_config,
170-
vector_config=vector_config,
171162
)
172163
return collection
173164
except Exception as e:
@@ -324,9 +315,6 @@ def __call__(
324315
vectorizer_config: Optional[
325316
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
326317
] = None,
327-
vector_config: Optional[
328-
Optional[Union[_VectorConfigCreate, List[_VectorConfigCreate]]]
329-
] = None,
330318
) -> Collection[Any, Any]:
331319
"""Typing for fixture."""
332320
...
@@ -341,18 +329,17 @@ def _factory(
341329
vectorizer_config: Optional[
342330
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
343331
] = None,
344-
vector_config: Optional[
345-
Optional[Union[_VectorConfigCreate, List[_VectorConfigCreate]]]
346-
] = None,
347332
) -> Collection[Any, Any]:
348333
api_key = os.environ.get("OPENAI_APIKEY")
349334
if api_key is None:
350335
pytest.skip("No OpenAI API key found.")
351336

337+
if vectorizer_config is None:
338+
vectorizer_config = Configure.Vectorizer.none()
339+
352340
collection = collection_factory(
353341
name=name,
354-
vectorizer_config=vectorizer_config,
355-
vector_config=vector_config or Configure.Vectors.self_provided(),
342+
vectorizer_config=vectorizer_config or Configure.Vectorizer.none(),
356343
properties=[
357344
Property(name="text", data_type=DataType.TEXT),
358345
Property(name="content", data_type=DataType.TEXT),

integration/test_client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import Callable, Generator, Optional, Tuple, Union
1+
from typing import Callable, Generator, Tuple, Union
22

33
import pytest
44
from _pytest.fixtures import SubRequest
@@ -28,7 +28,7 @@
2828

2929
@pytest.fixture(scope="module")
3030
def client_factory() -> Generator[Callable[[int, int], weaviate.WeaviateClient], None, None]:
31-
client: Optional[weaviate.WeaviateClient] = None
31+
client: weaviate.WeaviateClient = None
3232

3333
def maker(http: int, grpc: int) -> weaviate.WeaviateClient:
3434
nonlocal client
@@ -593,7 +593,7 @@ async def test_async_client_with_extra_options() -> None:
593593

594594
def test_client_error_for_wcs_without_auth() -> None:
595595
with pytest.raises(weaviate.exceptions.AuthenticationFailedError) as e:
596-
weaviate.connect_to_wcs(cluster_url=WCS_URL, auth_credentials=None) # pyright: ignore
596+
weaviate.connect_to_wcs(cluster_url=WCS_URL, auth_credentials=None)
597597
assert "wvc.init.Auth.api_key" in e.value.message
598598

599599

0 commit comments

Comments
 (0)