From a44ad580c11bc6bc4b278611f6c89c042843c5e7 Mon Sep 17 00:00:00 2001 From: Dirk Kulawiak Date: Wed, 8 Apr 2026 10:33:34 -0700 Subject: [PATCH 1/8] Skip async replication test for old version --- integration/test_collection_config.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/integration/test_collection_config.py b/integration/test_collection_config.py index 371405a1d..4dd9f8df5 100644 --- a/integration/test_collection_config.py +++ b/integration/test_collection_config.py @@ -1585,6 +1585,10 @@ def test_replication_config_without_async_config(collection_factory: CollectionF def test_replication_config_with_async_config(collection_factory: CollectionFactory) -> None: + collection_dummy = collection_factory("dummy") + if collection_dummy._connection._weaviate_version.is_lower_than(1, 34, 18): + pytest.skip("async replication config requires Weaviate >= 1.34.18") + collection = collection_factory( replication_config=Configure.replication( factor=1, From 2edb8739934c7c64356ea7f870b155ae40de9f37 Mon Sep 17 00:00:00 2001 From: Dirk Kulawiak Date: Wed, 8 Apr 2026 10:52:55 -0700 Subject: [PATCH 2/8] Use latest version in CI --- .github/workflows/main.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index 1fa7afb20..a9b14ed94 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -26,8 +26,8 @@ env: WEAVIATE_132: 1.32.23 WEAVIATE_133: 1.33.10 WEAVIATE_134: 1.34.5 - WEAVIATE_135: 1.35.0 - WEAVIATE_136: 1.36.0 + WEAVIATE_135: 1.35.16 + WEAVIATE_136: 1.36.9 WEAVIATE_137: 1.37.0-dev-29d5c87.amd64 From d040c0783df451fe7ae9abf0aaafa40bc60f0ae6 Mon Sep 17 00:00:00 2001 From: Dirk Kulawiak Date: Wed, 8 Apr 2026 11:03:39 -0700 Subject: [PATCH 3/8] Update more versions --- .github/workflows/main.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index a9b14ed94..402406230 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -28,7 +28,7 @@ env: WEAVIATE_134: 1.34.5 WEAVIATE_135: 1.35.16 WEAVIATE_136: 1.36.9 - WEAVIATE_137: 1.37.0-dev-29d5c87.amd64 + WEAVIATE_137: 1.37.0-rc.0-7afdd36 jobs: From 98a209f35040a2de103054b6f3ad4194c385db75 Mon Sep 17 00:00:00 2001 From: Dirk Kulawiak Date: Wed, 8 Apr 2026 11:29:59 -0700 Subject: [PATCH 4/8] adapt more tests --- integration/test_client.py | 31 --------------------------- integration/test_collection_config.py | 4 ++-- 2 files changed, 2 insertions(+), 33 deletions(-) diff --git a/integration/test_client.py b/integration/test_client.py index 23ece9885..b72f53655 100644 --- a/integration/test_client.py +++ b/integration/test_client.py @@ -360,37 +360,6 @@ def test_client_cluster_with_lazy_shard_loading( client.collections.delete(request.node.name) -def test_client_cluster_without_lazy_shard_loading( - client_factory: ClientFactory, request: SubRequest -) -> None: - client = client_factory(8090, 50061) - - try: - collection = client.collections.create( - name=request.node.name, vectorizer_config=Configure.Vectorizer.none() - ) - - nodes = client.cluster.nodes(collection.name, output="verbose") - assert len(nodes) == 1 - assert len(nodes[0].shards) == 1 - assert nodes[0].shards[0].collection == collection.name - assert nodes[0].shards[0].object_count == 0 - assert nodes[0].shards[0].vector_indexing_status in [ - "READONLY", - "INDEXING", - "READY", - "LAZY_LOADING", - ] - assert nodes[0].shards[0].vector_queue_length == 0 - assert nodes[0].shards[0].compressed is False - if collection._connection._weaviate_version.is_lower_than(1, 25, 0): - assert nodes[0].shards[0].loaded is True - else: - assert nodes[0].shards[0].loaded is False - finally: - client.collections.delete(request.node.name) - - def test_client_cluster_multitenant(client: weaviate.WeaviateClient, request: SubRequest) -> None: try: collection = client.collections.create( diff --git a/integration/test_collection_config.py b/integration/test_collection_config.py index 4dd9f8df5..d634e66cb 100644 --- a/integration/test_collection_config.py +++ b/integration/test_collection_config.py @@ -1730,7 +1730,7 @@ def test_replication_config_add_async_config_to_existing_collection( collection.config.update( replication_config=Reconfigure.replication( async_config=Reconfigure.Replication.async_config( - max_workers=12, + max_workers=8, propagation_concurrency=4, ), ), @@ -1738,7 +1738,7 @@ def test_replication_config_add_async_config_to_existing_collection( config = collection.config.get() assert config.replication_config.async_config is not None ac = config.replication_config.async_config - assert ac.max_workers == 12 + assert ac.max_workers == 8 assert ac.propagation_concurrency == 4 From 8457c53dae3926ff35b176ac6579c3b6cf4164c9 Mon Sep 17 00:00:00 2001 From: Dirk Kulawiak Date: Thu, 9 Apr 2026 10:08:24 -0700 Subject: [PATCH 5/8] Update versions to include filter bug --- .github/workflows/main.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index 402406230..d8f35963d 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -26,9 +26,9 @@ env: WEAVIATE_132: 1.32.23 WEAVIATE_133: 1.33.10 WEAVIATE_134: 1.34.5 - WEAVIATE_135: 1.35.16 - WEAVIATE_136: 1.36.9 - WEAVIATE_137: 1.37.0-rc.0-7afdd36 + WEAVIATE_135: 1.35.16-efdedfa + WEAVIATE_136: 1.36.9-d905e6c + WEAVIATE_137: 1.37.0-rc.0-b313954.amd64 jobs: From 02785d4246edc2d4f6d14bb9964ab7cad4ffb98b Mon Sep 17 00:00:00 2001 From: Dirk Kulawiak Date: Thu, 9 Apr 2026 10:18:49 -0700 Subject: [PATCH 6/8] Add missing comma --- .github/workflows/main.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index d8f35963d..2f68432ba 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -310,7 +310,7 @@ jobs: $WEAVIATE_133, $WEAVIATE_134, $WEAVIATE_135, - $WEAVIATE_136 + $WEAVIATE_136, $WEAVIATE_137 ] steps: From af8e3b1912d3d3f1412943bbc7d8030e0c61c5eb Mon Sep 17 00:00:00 2001 From: Dirk Kulawiak Date: Thu, 9 Apr 2026 10:39:20 -0700 Subject: [PATCH 7/8] Fix wrong parameter name in test --- integration/test_backup_v4.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/integration/test_backup_v4.py b/integration/test_backup_v4.py index 1204a1269..6da10bc7c 100644 --- a/integration/test_backup_v4.py +++ b/integration/test_backup_v4.py @@ -764,7 +764,7 @@ def test_incremental_backup(client: weaviate.WeaviateClient, request: SubRequest backend=BACKEND, include_collections=["Article"], wait_for_completion=True, - incremental_backup_base_id=base_backup_id, + incremental_base_backup_id=base_backup_id, ) # remove existing class From 8de3b891a68a6439c04fb9b903cdcfbcb304d864 Mon Sep 17 00:00:00 2001 From: Dirk Kulawiak Date: Thu, 9 Apr 2026 10:59:24 -0700 Subject: [PATCH 8/8] Lower case base backup id --- weaviate/backup/executor.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/weaviate/backup/executor.py b/weaviate/backup/executor.py index e8c52239d..b50515a2f 100644 --- a/weaviate/backup/executor.py +++ b/weaviate/backup/executor.py @@ -92,7 +92,11 @@ def create( "id": backup_id, "include": include_collections, "exclude": exclude_collections, - "incremental_base_backup_id": incremental_base_backup_id, + "incremental_base_backup_id": ( + incremental_base_backup_id.lower() + if incremental_base_backup_id is not None + else None + ), } if config is not None: