-
Notifications
You must be signed in to change notification settings - Fork 137
feat(config): add runtime property reindex support (Weaviate v1.39 GA API) #2098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
g-despot
wants to merge
12
commits into
dev/1.39
Choose a base branch
from
feat/runtime-property-reindex
base: dev/1.39
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5e7179c
feat: add runtime property reindex API for Weaviate >= 1.39 (#2097)
g-despot 762e656
test: cover runtime property reindex endpoints (#2097)
g-despot 6bcb4c5
fix: address review findings for property reindex API (#2097)
g-despot ce26136
fix: validate reindex arguments before use (#2098 review)
g-despot b3bafa2
fix: neutral error message for property index deletion (#2098)
g-despot a64ec15
feat: accept PropertyIndexType enum for index_name arguments (#2098)
g-despot 0120c65
docs: state the coupled retokenization contract explicitly (#2098)
g-despot e65fa0b
fix: drop internal alias wording, extend route-equality coverage (#2098)
g-despot d4a4ef4
refactor: scope reindex type names to inverted indexes (#2098)
g-despot fbe4a63
refactor: require InvertedIndexType on the new reindex methods (#2098)
g-despot 490d81b
Merge branch 'main' into feat/runtime-property-reindex
g-despot de8c7be
fix: align CI and task-status handling with final 1.39 semantics (#2098)
g-despot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test gap — only the idempotent
NO_OPcancel path is covered end-to-end. An actualCANCELLEDresult is mock-only, so the one branch that does real work on the server is unproven.Cancelling the in-flight coupled task from
test_property_reindex_coupled_tokenization_change(which inserts 100 objects specifically so the task stays live) would exercise it, and would also coverReindexCanceledErroron the wait path.