feat(core): add aiLocateAll batch locator#2700
Conversation
Deploying midscene with
|
| Latest commit: |
23084fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0a87e4d6.midscene.pages.dev |
| Branch Preview URL: | https://codex-ai-locate-all-batch.midscene.pages.dev |
b3f0ccc to
0b05ea0
Compare
0b05ea0 to
23084fd
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23084fd861
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| const rawResponse = JSON.stringify(res.content); | ||
| const errors: string[] = Array.isArray(res.content.errors) |
There was a problem hiding this comment.
Guard null locate-all responses before reading fields
If a model returns valid JSON null for a malformed/no-match locate-all response, callAIWithObjectResponse can pass it through because typeof null === 'object', and this dereference throws a TypeError before the intended fatal-response branch can create a ServiceError dump. Please validate res.content is a non-null object before reading errors or elements so malformed locate-all responses fail with the report dump preserved.
Useful? React with 👍 / 👎.
Summary
agent.aiLocateAll()and YAMLaiLocateAllusing the API shape from PR feat(core): add aiLocateAll (#1848) #1914Review doc
Feishu/Lark: https://bytedance.larkoffice.com/docx/O8wNdae2JoJhv1xzbzocgdf8nLR
Validation
pnpm exec tsc --noEmit --project packages/core/tsconfig.jsonpnpm exec tsc --noEmit --project apps/report/tsconfig.jsonpnpm --dir packages/core exec vitest run tests/unit-test/inspect-locate-all.test.ts tests/unit-test/service-locate-all.test.ts tests/unit-test/task-builder.test.ts tests/unit-test/agent-locate-all.test.ts tests/unit-test/player-action-dispatch.test.tspnpm --dir packages/web-integration exec vitest run tests/unit-test/yaml/player.test.tspnpm run lintnpx nx build @midscene/corenpx nx build @midscene/report