Skip to content

feat: include server directory in tsconfig.json from @modernjs/create template#8621

Open
s-r-x wants to merge 2 commits into
web-infra-dev:mainfrom
s-r-x:fix/default-tsconfig
Open

feat: include server directory in tsconfig.json from @modernjs/create template#8621
s-r-x wants to merge 2 commits into
web-infra-dev:mainfrom
s-r-x:fix/default-tsconfig

Conversation

@s-r-x
Copy link
Copy Markdown

@s-r-x s-r-x commented May 19, 2026

Summary

modern/modern.server.ts is ignored if the folder isn't included in tsconfig.json

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

⚠️ No Changeset found

Latest commit: 6424c3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented May 19, 2026

Deploy Preview for modernjs-byted ready!

Name Link
🔨 Latest commit 6424c3b
🔍 Latest deploy log https://app.netlify.com/projects/modernjs-byted/deploys/6a0c5897cb6d7f0008b0113e
😎 Deploy Preview https://deploy-preview-8621--modernjs-byted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@s-r-x s-r-x changed the title Fix/default tsconfig feat: include server directory in tsconfig.json from @modernjs/create template May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant