fix(server-core): type matchRoute miss explicitly instead of casting [] to a matched tuple#8754
Open
BleedingDev wants to merge 2 commits into
Open
Conversation
…[] to a matched tuple
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 79de5d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 117 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
matchRoutetyped every result as[ServerRoute, Params]even when the Hono router found no route. On a miss it returned[], so destructuring producedundefinedwhile TypeScript still treated the value as a validServerRoute.Fix
Represent misses as
[ServerRoute | undefined, Params]and return[undefined, {}]. The helper now narrows Hono route tuples before returning matched params.Test
Added a render unit test that asserts unmatched route matching returns an undefined route with empty params. Ran
PUPPETEER_SKIP_DOWNLOAD=1 pnpm install,pnpm --filter @modern-js/server-core build, andpnpm --filter @modern-js/server-core test.🤖 Generated with Claude Code