fix(server): add CORS headers to the lazy-compilation trigger endpoint#8777
Open
keepview wants to merge 1 commit into
Open
fix(server): add CORS headers to the lazy-compilation trigger endpoint#8777keepview wants to merge 1 commit into
keepview wants to merge 1 commit into
Conversation
When a page is served from a proxied domain (Whistle / Eden Proxy mapping an online domain to the local dev server) while lazyCompilation.serverUrl points at 127.0.0.1 (derived from dev.client), the lazy trigger POST is cross-origin. Rspack's middleware replies without CORS headers: the request still reaches the compiler and invalidates the build, but the browser blocks the response, so dynamic imports fail and the page reload-loops. Register a scoped middleware before rsbuild-dev that reflects the Origin for the lazy-compilation prefixes only (resolved from the compiler options) and answers CORS/PNA preflights. The endpoint only triggers compilation and never returns source; the global server.cors config stays untouched.
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 6cdf04f The changes in this PR will be included in the next version bump. This PR includes changesets to release 118 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a page is served from a proxied domain (Whistle / Eden Proxy mapping an online domain to the local dev server) while lazyCompilation.serverUrl points at 127.0.0.1 (derived from dev.client), the lazy trigger POST is cross-origin. Rspack's middleware replies without CORS headers: the request still reaches the compiler and invalidates the build, but the browser blocks the response, so dynamic imports fail and the page reload-loops.
Register a scoped middleware before rsbuild-dev that reflects the Origin for the lazy-compilation prefixes only (resolved from the compiler options) and answers CORS/PNA preflights. The endpoint only triggers compilation and never returns source; the global server.cors config stays untouched.
Summary
Related Links
Checklist
pnpm run change.