Skip to content

perf(core): minify large third-party chunks #8160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Jul 22, 2026
+44 −11
Merged

perf(core): minify large third-party chunks #8160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/core/rslib.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ export const define = {
'process.env.WS_NO_UTF_8_VALIDATE': true,
};

const fullyMinifiedChunks =
/^(?:chokidar|connect-next|http-proxy-middleware|launch-editor-middleware|manifest-plugin|memfs|open|tinyglobby|ws)\.js$/;

const regexpMap: Record<string, RegExp> = {};

for (const item of prebundleConfig.dependencies) {
Expand Down Expand Up @@ -204,7 +207,18 @@ export default defineConfig({
},
},
output: {
minify: nodeMinifyConfig,
minify: {
jsOptions: [
{
// Fully minify large chunks composed primarily of third-party code.
include: fullyMinifiedChunks,
},
{
...nodeMinifyConfig.jsOptions,
exclude: fullyMinifiedChunks,
},
],
},
Comment thread
chenjiahan marked this conversation as resolved.
filename: {
js: ({ chunk }) => {
// Use `.mjs` for Rspack loaders
Expand Down
35 changes: 27 additions & 8 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions scripts/config/rslib.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { pluginAreTheTypesWrong } from 'rsbuild-plugin-arethetypeswrong';

export const commonExternals: Array<string | RegExp> = ['webpack', /[\\/]compiled[\\/]/];

export const nodeMinifyConfig: Rsbuild.Minify = {
export const nodeMinifyConfig = {
js: true,
css: false,
jsOptions: {
Expand All @@ -16,7 +16,7 @@ export const nodeMinifyConfig: Rsbuild.Minify = {
},
},
},
};
} satisfies Rsbuild.Minify;

export const esmConfig: LibConfig = {
syntax: 'es2023',
Expand Down