Skip to content

chore: migrate Rstest to Rstack CLI#8166

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore-rstack-cli-test
Jul 22, 2026
Merged

chore: migrate Rstest to Rstack CLI#8166
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore-rstack-cli-test

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

This PR migrates the monorepo's Rstest commands and configurations to Rstack CLI while preserving the existing unit and E2E behavior. It replaces direct @rstest/core imports and type entries with rstack/test, removes the direct core dependency outside the create-rsbuild templates, and keeps the explicit Rslib adapter and Playwright integrations. The temporary Playwright hook type workaround links to the upstream fix and can be removed after it is released.

Related Links

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 25b0eecb-3c65-436b-ae5b-d60650aba689

📥 Commits

Reviewing files that changed from the base of the PR and between 12da47d and 3bb8fda.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (22)
  • e2e/helper/fixture.ts
  • e2e/package.json
  • e2e/rstack.config.ts
  • e2e/rstest.config.ts
  • e2e/tsconfig.json
  • package.json
  • packages/core/tests/tsconfig.json
  • packages/plugin-babel/tests/tsconfig.json
  • packages/plugin-less/tests/tsconfig.json
  • packages/plugin-preact/tests/tsconfig.json
  • packages/plugin-react/tests/tsconfig.json
  • packages/plugin-sass/tests/tsconfig.json
  • packages/plugin-solid/tests/tsconfig.json
  • packages/plugin-svelte/tests/tsconfig.json
  • packages/plugin-svgr/tests/tsconfig.json
  • packages/plugin-tailwindcss/tests/tsconfig.json
  • packages/plugin-vue/tests/tsconfig.json
  • pnpm-workspace.yaml
  • rstack.config.ts
  • rstest.config.ts
  • scripts/test-helper/rstest.setup.ts
  • scripts/test-helper/tsconfig.json
💤 Files with no reviewable changes (3)
  • e2e/rstest.config.ts
  • rstest.config.ts
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

The test setup was migrated from direct rstest usage to rstack test. Root and E2E configurations now use define.test, package scripts invoke rs test, and obsolete @rstest/core dependency entries were removed. Test TypeScript configurations now use rstack/test/globals, setup imports use rstack/test, and E2E fixture typings define custom rstack-compatible test signatures.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: migrating Rstest to the Rstack CLI.
Description check ✅ Passed The description is directly related to the PR and accurately describes the migration and temporary workaround.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan
chenjiahan merged commit 3e62fc9 into main Jul 22, 2026
7 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/chore-rstack-cli-test branch July 22, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant