chore(build): simplify Rslib configs#8168
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughUpdated shared Rslib configuration by removing type-checking plugin integration, rspack settings, and unused package variants. Removed the associated dependency from the workspace catalog and configuration package. Less and Sass now exclude compiled paths from bundling. Solid now explicitly defines ESM and CommonJS builds, with ES2023 syntax and Node-based minification for the CommonJS output. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The shared Rslib configuration currently carries options used by only a subset of packages. This PR moves the Solid dual-package setup and compiled externals into package-local configs, removes the unused
rsbuild-plugin-arethetypeswrongintegration, and relies on existing minification defaults. Generated package artifacts remain unchanged.