Skip to content

chore(build): simplify Rslib configs#8168

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore-simplify-rslib-config
Jul 22, 2026
Merged

chore(build): simplify Rslib configs#8168
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore-simplify-rslib-config

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

The shared Rslib configuration currently carries options used by only a subset of packages. This PR moves the Solid dual-package setup and compiled externals into package-local configs, removes the unused rsbuild-plugin-arethetypeswrong integration, and relies on existing minification defaults. Generated package artifacts remain unchanged.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 31bb79b1-0b23-4df9-b780-abefb0b0dd1e

📥 Commits

Reviewing files that changed from the base of the PR and between bb8ecd1 and 77e422b.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • packages/plugin-less/rslib.config.ts
  • packages/plugin-sass/rslib.config.ts
  • packages/plugin-solid/rslib.config.ts
  • pnpm-workspace.yaml
  • scripts/config/package.json
  • scripts/config/rslib.config.ts
💤 Files with no reviewable changes (3)
  • scripts/config/package.json
  • pnpm-workspace.yaml
  • scripts/config/rslib.config.ts

📝 Walkthrough

Walkthrough

Updated shared Rslib configuration by removing type-checking plugin integration, rspack settings, and unused package variants. Removed the associated dependency from the workspace catalog and configuration package. Less and Sass now exclude compiled paths from bundling. Solid now explicitly defines ESM and CommonJS builds, with ES2023 syntax and Node-based minification for the CommonJS output.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: simplifying Rslib configs.
Description check ✅ Passed The description matches the changes by describing the shared config cleanup and package-local moves.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan
chenjiahan merged commit 7ed2a1a into main Jul 22, 2026
7 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/chore-simplify-rslib-config branch July 22, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant