chore(deps): update typescript and nodejs->24#1658
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92d6163fa2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR aims to update the workspace’s TypeScript dependency via the pnpm catalog and regenerate the lockfile accordingly, but the actual change pins TypeScript to 1.6.2 (a major downgrade) which is incompatible with tooling in the repo.
Changes:
- Updated
catalog.typescriptinpnpm-workspace.yaml. - Regenerated
pnpm-lock.yamlto reflect the new catalog resolution (propagatingtypescript@1.6.2through many peers/snapshots).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Changes the pnpm catalog TypeScript version (currently pinned to 1.6.2). |
| pnpm-lock.yaml | Lockfile updates reflecting the catalog change, including new typescript@1.6.2 snapshots/peer resolutions. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying rsdoctor with
|
| Latest commit: |
0c408a4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://60bc5d13.rsdoctor.pages.dev |
| Branch Preview URL: | https://update-rsdoctor-typescript.rsdoctor.pages.dev |
yifancong
force-pushed
the
update-rsdoctor-typescript
branch
from
ce06e52 to
acc7388
Compare
yifancong
changed the title
chore(deps): update node types to 24 chore(deps): refresh typescript lockfile fix: support TypeScript 6 config Chore(deps): update typescript to 6.0.3 chore(deps): update typescript chore(agent-cli): remove ignoreDeprecations from tsconfig chore(deps): update typescript
yifancong
force-pushed
the
update-rsdoctor-typescript
branch
from
2cad6ea to
0c408a4
Compare
Summary
This pull request primarily updates TypeScript configuration across multiple packages and example projects to simplify the
tsconfig.jsonfiles by removing unnecessarybaseUrlsettings and to improve type support by upgrading the@types/nodedependency. Additionally, there are minor improvements to type annotations and path mappings.TypeScript Configuration Simplification:
baseUrlsetting fromtsconfig.jsonin multiple packages and example projects to rely on default resolution and reduce configuration complexity.packages/components/tsconfig.jsonfor better module resolution (srcandsrc/*).Dependency Updates:
@types/nodefrom version^22.8.1to^24.12.3in several example projects to ensure compatibility with newer Node.js APIs.Type Annotation Improvements:
rulesinpackages/core/src/rules/rules/index.tsfor improved type safety.React.FCtype annotations to components wrapped withwithServerAPIfor better type inference inpackages/components/src/components/Configuration/builder.tsxandpackages/components/src/components/Loader/Analysis/index.tsx.Related Links