perf(cli): remove process title startup overhead#1649
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the process.title = 'rslib-node' assignment from the Rslib CLI startup path to eliminate the synchronous native overhead it incurs, mirroring the equivalent optimization made in Rsbuild (#7657).
Changes:
- Drop the
process.titleassignment and its accompanying comment fromrunCLI().
chenjiahan
changed the title
Timeless0911
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the Rslib CLI startup code that updates
process.title. Updating the process title is a synchronous native operation and adds measurable overhead for short-lived CLI commands, while the title is not required for CLI correctness.The equivalent Rsbuild change improved
rsbuild buildby18.501 msmean time in a 30-runreact-1kbenchmark and by10.018 msmean time in an 80-run benchmark.Related Links
web-infra-dev/rsbuild#7657
nodejs/node#59678
Checklist