Skip to content

ci: allow ecosystem CI commit comments#1657

Merged
chenjiahan merged 1 commit into
mainfrom
david/chore-align-ci-rsbuild
May 20, 2026
Merged

ci: allow ecosystem CI commit comments#1657
chenjiahan merged 1 commit into
mainfrom
david/chore-align-ci-rsbuild

Conversation

@Timeless0911
Copy link
Copy Markdown
Contributor

Summary

Restore the contents: write permission for the per-commit ecosystem CI job so the failure-reporting path can create commit comments after downstream ecosystem CI failures. The other narrowed permissions remain unchanged.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings May 20, 2026 03:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores the GitHub Actions job-level GITHUB_TOKEN permission needed for the per-commit Ecosystem CI workflow path to create/update commit comments when downstream ecosystem CI fails.

Changes:

  • Updated ecosystem_ci_per_commit job permissions from contents: read to contents: write to allow commit comment creation (used via updateComment: true in the action payload).

@chenjiahan chenjiahan merged commit c248e09 into main May 20, 2026
17 of 18 checks passed
@chenjiahan chenjiahan deleted the david/chore-align-ci-rsbuild branch May 20, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants