feat(core): use modern-module externals type for Node ESM

[Timeless0911]

Summary

This PR changes the default ESM externalsType to modern-module only for output.target: 'node', so CommonJS require() externals in Node ESM output use Rspack's modern createRequire handling. Browser ESM output keeps the previous module-import default to avoid emitting Node-specific node:module code paths.

It also removes the old CommonJS external warning path and the now-unneeded autoCjsNodeBuiltin RslibPlugin option, then updates the externals docs and integration coverage for node/web ESM behavior and supported external type forms.

Related Links

https://rspack.rs/config/externals#externalstypemodern-module
https://rspack.rs/config/externals#externalstypemodule-import

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).

[cloudflare-workers-and-pages]

Deploying rslib with    Cloudflare Pages

Latest commit:	7baca3e
Status:	✅  Deploy successful!
Preview URL:	https://175bfc21.rslib.pages.dev
Branch Preview URL:	https://david-modern-module-external.rslib.pages.dev

View logs

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87ff22e106

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated no new comments.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

[Timeless0911]

pending

1. Rspack support bundle createRequire
2. modern-module external type now depends externalsPreset.node to determine node target, but Rslib set externalsPreset.node to false since fix: remove externalsPresets.node #1318 due to externals: { fs: false } can not takes effect with externalsPreset which should be a bug of Rspack externals?

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7baca3eb91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Gate modern-module default to Node targets

For format: 'esm' with output.target: 'web', this default now applies modern-module to auto/user externals as well; the current patch’s own docs (website/docs/en/config/rsbuild/output.mdx line 90) confirm that CommonJS require() externals on non-Node targets are emitted as bare require() calls. That regresses web-target ESM bundles that externalize a dependency used via require() (including auto-external dependencies), because browsers do not provide require, whereas the previous module-import fallback emitted ESM imports for these cases. Please keep module-import for web targets or make this mapping target-aware.

Useful? React with 👍 / 👎.