Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a suite of benchmarks for workspace ownership and various linter operations, including syntax, type-aware, and semantic diagnostic checks. It also adds a CodSpeed badge to the README. The review feedback highlights several opportunities to improve benchmark accuracy by moving closure allocations and slice initializations outside of the timing loops to reduce measurement noise. Additionally, it identifies a potential race condition in global benchmark sinks that should be addressed using atomic operations to ensure thread safety during parallel execution.
Congrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
5b55365 to
a1430a8
Compare
92eb309 to
0f80140
Compare
0f80140 to
f0c1480
Compare
f0c1480 to
240ca99
Compare
Summary
benchmark-gojob in CI to run CodSpeed walltime benchmarks for./internal/linterbenchmark-clijob in CI to run CLI walltime benchmarks throughpnpm run bench:clidonejob so release-branch benchmark jobs are required alongside the existing CI jobspackage.json, includingpnpm run bench:goandpnpm run bench:cliRelated Links
see example: chore/release-xxx 👉 #748
Checklist