refactor: remove runtime module prefix accessor

Author: LingyuCoder

crates/rspack_binding_api/src/plugins/interceptor.rs

@@ -1489,6 +1489,11 @@ impl CompilationRuntimeModule for CompilationRuntimeModuleTap {
       runtime_template: &runtime_template,
     };
     let source_string = module.generate(&context).await?;
+    let runtime_module_prefix = if compilation.runtime_template.render_mode().is_legacy() {
+      "webpack/runtime/"
+    } else {
+      "rspack/runtime/"
+    };
     let arg = JsRuntimeModuleArg {
       module: JsRuntimeModule {
         source: Some(JsSourceToJs::from(source_string)),
@@ -1497,7 +1502,7 @@ impl CompilationRuntimeModule for CompilationRuntimeModuleTap {
         name: module
           .name()
           .as_str()
-          .cow_replace(compilation.runtime_template.runtime_module_prefix(), "")
+          .cow_replace(runtime_module_prefix, "")
           .into_owned(),
         stage: module.stage().into(),
         isolate: module.should_isolate(compilation.options.experiments.runtime_mode),

crates/rspack_core/src/runtime_template.rs

@@ -100,6 +100,11 @@ pub enum RuntimeTemplateRenderMode {
 }
 
 impl RuntimeTemplateRenderMode {
+  /// Returns whether all runtime globals use webpack-compatible identifiers.
+  pub fn is_legacy(self) -> bool {
+    matches!(self, Self::Webpack)
+  }
+
   /// Returns the runtime-global render mode for ordinary module code generation.
   pub fn module_render_mode(self) -> RuntimeGlobalsRenderMode {
     match self {
@@ -123,13 +128,6 @@ impl RuntimeTemplateRenderMode {
       Self::Rspack => RuntimeGlobalsRenderMode::RspackContext,
     }
   }
-
-  fn runtime_module_prefix(self) -> &'static str {
-    match self {
-      Self::Webpack => "webpack/runtime/",
-      Self::Rspack => "rspack/runtime/",
-    }
-  }
 }
 
 impl From<RuntimeMode> for RuntimeTemplateRenderMode {
@@ -256,7 +254,7 @@ impl RuntimeTemplate {
       })),
     );
 
-    let runtime_globals_cloned = runtime_globals.clone();
+    let runtime_globals_cloned = runtime_globals;
     dojang.functions.insert(
       "weak".into(),
       FunctionContainer::F1(Box::new(move |runtime_global: Operand| {
@@ -283,8 +281,9 @@ impl RuntimeTemplate {
     }
   }
 
-  pub fn runtime_module_prefix(&self) -> &'static str {
-    self.render_mode.runtime_module_prefix()
+  /// Returns the render-mode combination selected for this compilation.
+  pub fn render_mode(&self) -> RuntimeTemplateRenderMode {
+    self.render_mode
   }
 
   pub fn create_runtime_module_identifier(&self, name: &str) -> Identifier {
@@ -293,15 +292,16 @@ impl RuntimeTemplate {
     } else {
       name
     };
-    Identifier::from(format!(
-      "{}{}",
-      self.runtime_module_prefix(),
-      module_name.to_snake_case()
-    ))
+    self.create_custom_runtime_module_identifier(&module_name.to_snake_case())
   }
 
   pub fn create_custom_runtime_module_identifier(&self, custom: &str) -> Identifier {
-    Identifier::from(format!("{}{custom}", self.runtime_module_prefix()))
+    let prefix = if self.render_mode.is_legacy() {
+      "webpack/runtime/"
+    } else {
+      "rspack/runtime/"
+    };
+    Identifier::from(format!("{prefix}{custom}"))
   }
 
   /// Creates the template used to render runtime globals referenced by ordinary modules.

crates/rspack_plugin_runtime/src/runtime_module/export_require.rs

@@ -12,10 +12,10 @@ pub struct ExportRequireRuntimeModule {}
 
 impl ExportRequireRuntimeModule {
   pub fn new(runtime_template: &RuntimeTemplate) -> Self {
-    let name = if runtime_template.runtime_module_prefix() == "rspack/runtime/" {
-      EXPORT_REQUIRE_RSPACK_RUNTIME_MODULE_ID
-    } else {
+    let name = if runtime_template.render_mode().is_legacy() {
       EXPORT_REQUIRE_RUNTIME_MODULE_ID
+    } else {
+      EXPORT_REQUIRE_RSPACK_RUNTIME_MODULE_ID
     };
     Self::with_name(runtime_template, name)
   }