fix: arc from str

Author: SyMind

crates/rspack_binding_api/src/raw_options/raw_builtins/raw_context_replacement.rs

@@ -1,3 +1,5 @@
+use std::sync::Arc;
+
 use napi::bindgen_prelude::Object;
 use napi_derive::napi;
 use rspack_error::{Error, ToStringResultToRspackResultExt};
@@ -36,7 +38,7 @@ impl<'a> TryFrom<RawContextReplacementPluginOptions<'a>> for ContextReplacementP
       for key in keys {
         let value = raw.get::<String>(&key).to_rspack_result()?;
         if let Some(value) = value {
-          map.insert(key, value);
+          map.insert(Arc::from(key), value);
         }
       }
       Some(map)

crates/rspack_core/src/context_module_factory.rs

@@ -510,7 +510,7 @@ async fn visit_dirs(
         dependencies.push(ContextElementDependency {
           id: DependencyId::new(),
           request: Arc::from(request),
-          user_request: Arc::from(r.request),
+          user_request: r.request.clone(),
           category: options.context_options.category,
           context: options.resource.clone().into(),
           layer: options.layer.clone(),
@@ -529,13 +529,16 @@ async fn visit_dirs(
 
 #[derive(Debug, Clone)]
 pub struct AlternativeRequest {
-  pub context: String,
-  pub request: String,
+  pub context: Arc<str>,
+  pub request: Arc<str>,
 }
 
 impl AlternativeRequest {
-  pub fn new(context: String, request: String) -> Self {
-    Self { context, request }
+  pub fn new(context: impl Into<Arc<str>>, request: impl Into<Arc<str>>) -> Self {
+    Self {
+      context: context.into(),
+      request: request.into(),
+    }
   }
 }
 

crates/rspack_plugin_esm_library/src/optimize_chunks.rs

@@ -601,7 +601,7 @@ pub(crate) fn assign_dyn_import_chunk_short_names(compilation: &mut Compilation)
 
   // Apply assignments
   for (chunk_ukey, name) in assignments {
-    let name_key: Arc<str> = Arc::from(name.into_boxed_str());
+    let name_key: Arc<str> = Arc::from(name);
     let chunk = compilation
       .build_chunk_graph_artifact
       .chunk_by_ukey

crates/rspack_plugin_extract_css/src/plugin.rs

@@ -707,7 +707,7 @@ async fn render_manifest(
   diagnostics.extend(more_diagnostics);
   manifest.push(RenderManifestEntry {
     source,
-    filename: Arc::from(filename.as_ref()),
+    filename: Arc::from(filename),
     has_filename: false,
     info: asset_info,
     auxiliary: false,

crates/rspack_plugin_html/src/asset.rs

@@ -62,7 +62,7 @@ impl HtmlPluginAssets {
               .entrypoints
               .contains_key(name.as_str())
           })
-          .map(|name| Arc::from(name.as_str()))
+          .map(|name| Arc::from(name.clone()))
           .collect()
       } else {
         compilation

crates/rspack_plugin_split_chunks/src/plugin/chunk.rs

@@ -16,7 +16,7 @@ fn put_split_chunk_reason(
   };
   if let Some(chunk_reason) = chunk_reason {
     chunk_reason.push(',');
-    chunk_reason.push_str(&reason);
+    chunk_reason.push_str(reason);
   } else {
     *chunk_reason = Some(reason.to_string());
   }