Skip to content

Commit 9f1b14a

Browse files
committed
test: enable TLA split-sync-modules tests that were previously skipped
Remove test.filter.js from split-sync-modules-{1,2,3} tests that were skipped with "cycle caused by available modules". These tests exercise the exact circular dependency scenario that extract_tla_shared_modules now fixes. Add warnings.js to expect the TLA circular dependency warning that is emitted when shared modules are extracted.
1 parent 89ed9ec commit 9f1b14a

7 files changed

Lines changed: 6 additions & 3 deletions

File tree

crates/rspack_plugin_esm_library/src/optimize_chunks.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,9 @@ pub(crate) fn extract_tla_shared_modules(compilation: &mut Compilation) -> bool
102102
module_graph,
103103
None,
104104
&compilation.module_graph_cache_artifact,
105+
&compilation
106+
.build_module_graph_artifact
107+
.side_effects_state_artifact,
105108
&compilation.exports_info_artifact,
106109
) {
107110
continue;

tests/rspack-test/esmOutputCases/top-level-await/split-sync-modules-1/test.filter.js

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
module.exports = [/Top-level await with shared modules caused a circular dependency/];

tests/rspack-test/esmOutputCases/top-level-await/split-sync-modules-2/test.filter.js

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
module.exports = [/Top-level await with shared modules caused a circular dependency/];

tests/rspack-test/esmOutputCases/top-level-await/split-sync-modules-3/test.filter.js

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
module.exports = [/Top-level await with shared modules caused a circular dependency/];

0 commit comments

Comments
 (0)