feat: enable createRequire parser for node targets

Author: JSerFeng

packages/rspack/src/config/defaults.ts

@@ -320,10 +320,12 @@ const applyJavascriptParserOptionsDefaults = (
     deferImport,
     sourceImport,
     outputModule,
+    isNode,
   }: {
     deferImport?: boolean;
     sourceImport?: boolean;
     outputModule: RspackOptionsNormalized['output']['module'];
+    isNode: boolean;
   },
 ) => {
   D(parserOptions, 'dynamicImportMode', 'lazy');
@@ -349,7 +351,7 @@ const applyJavascriptParserOptionsDefaults = (
   D(parserOptions, 'deferImport', deferImport);
   D(parserOptions, 'sourceImport', sourceImport);
   D(parserOptions, 'importMetaResolve', false);
-  D(parserOptions, 'createRequire', false);
+  D(parserOptions, 'createRequire', isNode);
 };
 
 const applyCssGeneratorOptionsDefaults = (
@@ -463,6 +465,7 @@ const applyModuleDefaults = (
     deferImport,
     sourceImport,
     outputModule,
+    isNode: targetProperties !== false && targetProperties.node === true,
   });
 
   F(module.parser, JSON_MODULE_TYPE, () => ({}));

packages/rspack/src/config/types.ts

@@ -1398,7 +1398,7 @@ export type JavascriptParserOptions = {
 
   /**
    * Enable or disable parsing `import { createRequire } from "module"` and evaluating createRequire().
-   * @default false
+   * @default true for Node.js-compatible targets, otherwise false
    */
   createRequire?: boolean | string;
 

tests/rspack-test/configCases/require/module-require/rspack.config.js

@@ -50,13 +50,6 @@ module.exports = {
     path: 'node-commonjs path',
   },
   target: 'node',
-  module: {
-    parser: {
-      javascript: {
-        createRequire: true,
-      },
-    },
-  },
   optimization: {
     inlineExports: true,
     moduleIds: 'named',

tests/rspack-test/defaultsCases/target_/electron-main.js

@@ -37,6 +37,9 @@ module.exports = {
 			-         "exportsOnly": false,
 			+         "exportsOnly": true,
 			@@ ... @@
+			-         "createRequire": false,
+			+         "createRequire": true,
+			@@ ... @@
 			-     "__dirname": "warn-mock",
 			-     "__filename": "warn-mock",
 			-     "global": "warn",

tests/rspack-test/defaultsCases/target_/electron-preload.js

@@ -35,6 +35,9 @@ module.exports = {
 			-         "exportsOnly": false,
 			+         "exportsOnly": true,
 			@@ ... @@
+			-         "createRequire": false,
+			+         "createRequire": true,
+			@@ ... @@
 			-     "__dirname": "warn-mock",
 			-     "__filename": "warn-mock",
 			-     "global": "warn",

tests/rspack-test/defaultsCases/target_/node-require-resolve-disabled.js

@@ -0,0 +1,22 @@
+/** @type {import('@rspack/test-tools').TDefaultsCaseConfig} */
+module.exports = {
+	description: "target node with requireResolve disabled",
+	options: () => ({
+		target: "node",
+		module: {
+			parser: {
+				javascript: {
+					requireResolve: false
+				}
+			}
+		}
+	}),
+	diff: e => {
+		e.toEqual({
+			value: expect.stringMatching(/\+\s+"requireResolve": false/)
+		});
+		e.toEqual({
+			value: expect.stringMatching(/\+\s+"createRequire": true/)
+		});
+	}
+};

tests/rspack-test/defaultsCases/target_/node.js

@@ -32,6 +32,9 @@ module.exports = {
 			-         "exportsOnly": false,
 			+         "exportsOnly": true,
 			@@ ... @@
+			-         "createRequire": false,
+			+         "createRequire": true,
+			@@ ... @@
 			-     "__dirname": "warn-mock",
 			-     "__filename": "warn-mock",
 			-     "global": "warn",

tests/rspack-test/defaultsCases/target_/nwjs.js

@@ -31,6 +31,9 @@ module.exports = {
 			-         "exportsOnly": false,
 			+         "exportsOnly": true,
 			@@ ... @@
+			-         "createRequire": false,
+			+         "createRequire": true,
+			@@ ... @@
 			-     "__dirname": "warn-mock",
 			-     "__filename": "warn-mock",
 			-     "global": "warn",

tests/rspack-test/esmOutputCases/create-require/import-meta-url-resolve-disabled/rspack.config.js

@@ -2,7 +2,6 @@ module.exports = {
   module: {
     parser: {
       javascript: {
-        createRequire: true,
         requireResolve: false,
       },
     },