refactor BYTE_LENGTH

Author: SyMind

crates/node_binding/napi-binding.d.ts

@@ -626,6 +626,8 @@ export declare enum BuiltinPluginName {
 
 export declare function cleanupGlobalTrace(): void
 
+export const COMPILATION_HOOK_SUBSCRIPTION_BITSET_BYTE_LENGTH: number
+
 export declare enum CompilationHooks {
   BuildModule = 0,
   StillValidModule = 1,
@@ -672,6 +674,8 @@ export declare enum CompilationHooks {
   RsdoctorPluginAssets = 42
 }
 
+export const COMPILER_HOOK_SUBSCRIPTION_BITSET_BYTE_LENGTH: number
+
 export declare enum CompilerHooks {
   ThisCompilation = 0,
   Compilation = 1,

crates/rspack_binding_api/src/plugins/interceptor.rs

@@ -194,15 +194,15 @@ impl HookSubscriptionBitsetView {
   pub(super) fn compiler(bitset: Buffer) -> Self {
     Self::new(
       bitset,
-      COMPILER_HOOK_SUBSCRIPTION_BITSET_BYTE_LENGTH,
+      COMPILER_HOOK_SUBSCRIPTION_BITSET_BYTE_LENGTH as usize,
       "compiler hook subscription bitset length mismatch",
     )
   }
 
   pub(super) fn compilation(bitset: Buffer) -> Self {
     Self::new(
       bitset,
-      COMPILATION_HOOK_SUBSCRIPTION_BITSET_BYTE_LENGTH,
+      COMPILATION_HOOK_SUBSCRIPTION_BITSET_BYTE_LENGTH as usize,
       "compilation hook subscription bitset length mismatch",
     )
   }
@@ -430,6 +430,10 @@ pub enum CompilerHooks {
 
 const COMPILER_HOOK_COUNT: usize = (CompilerHooks::AssetEmitted as usize) + 1;
 
+#[napi]
+pub const COMPILER_HOOK_SUBSCRIPTION_BITSET_BYTE_LENGTH: u32 =
+  ((COMPILER_HOOK_COUNT as u32 - 1) >> 3) + 1;
+
 #[napi]
 #[repr(u8)]
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
@@ -481,18 +485,9 @@ pub enum CompilationHooks {
 
 const COMPILATION_HOOK_COUNT: usize = (CompilationHooks::RsdoctorPluginAssets as usize) + 1;
 
-const fn hook_subscription_bitset_byte_length(kind_count: usize) -> usize {
-  if kind_count == 0 {
-    return 0;
-  }
-  ((kind_count - 1) >> 3) + 1
-}
-
-const COMPILER_HOOK_SUBSCRIPTION_BITSET_BYTE_LENGTH: usize =
-  hook_subscription_bitset_byte_length(COMPILER_HOOK_COUNT);
-
-const COMPILATION_HOOK_SUBSCRIPTION_BITSET_BYTE_LENGTH: usize =
-  hook_subscription_bitset_byte_length(COMPILATION_HOOK_COUNT);
+#[napi]
+pub const COMPILATION_HOOK_SUBSCRIPTION_BITSET_BYTE_LENGTH: u32 =
+  ((COMPILATION_HOOK_COUNT as u32 - 1) >> 3) + 1;
 
 #[derive(Clone)]
 #[napi(object, object_to_js = false)]

packages/rspack/src/BindingHooks.ts

@@ -16,18 +16,11 @@ type DefaultAdditionalOptions =
     ? A
     : never;
 
-const COMPILER_HOOK_COUNT = binding.CompilerHooks.AssetEmitted + 1;
-const COMPILATION_HOOK_COUNT =
-  binding.CompilationHooks.RsdoctorPluginAssets + 1;
-
-const getHookSubscriptionBitsetByteLength = (kindCount: number) =>
-  Math.max((kindCount - 1) >> 3, 0) + 1;
-
 export class HookSubscriptionBitset {
   readonly buffer: Buffer;
 
-  constructor(kindCount: number) {
-    this.buffer = Buffer.alloc(getHookSubscriptionBitsetByteLength(kindCount));
+  constructor(byteLength: number) {
+    this.buffer = Buffer.alloc(byteLength);
   }
 
   markSubscribed(bitIndex: number) {
@@ -50,10 +43,14 @@ export const COMPILATION_HOOK_SUBSCRIPTION_BITSETS = new WeakMap<
 >();
 
 export const createCompilerHookSubscriptionBitset = () =>
-  new HookSubscriptionBitset(COMPILER_HOOK_COUNT);
+  new HookSubscriptionBitset(
+    binding.COMPILER_HOOK_SUBSCRIPTION_BITSET_BYTE_LENGTH,
+  );
 
 export const createCompilationHookSubscriptionBitset = () =>
-  new HookSubscriptionBitset(COMPILATION_HOOK_COUNT);
+  new HookSubscriptionBitset(
+    binding.COMPILATION_HOOK_SUBSCRIPTION_BITSET_BYTE_LENGTH,
+  );
 
 export class BindingSyncHook<
   T = any,