chore: fix test failures on mf-layers#12992
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
ScriptedAlchemy
changed the title
📦 Binary Size-limit
❌ Size increased by 26.88KB from 48.59MB to 48.62MB (⬆️0.05%) |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65b1912264
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (delay > 0) { | ||
| await new Promise((resolve) => setTimeout(resolve, delay)); | ||
| } | ||
| copyDiff(path.join(context.getSource(), step), tempDir, false); |
There was a problem hiding this comment.
When nativeWatcher times out, this loop reruns copyDiff against the same step directory, but copyDiff treats DELETE marker files as fs.unlinkSync(destFile) and throws if the file was already removed on the first attempt. I checked tests/rspack-test/NativeWatcher.part*.test.js (which run watchCases) and those cases include DELETE markers such as watchCases/recover-from-error/delete-file/1/file.js, so a timeout now turns into an ENOENT failure on retry instead of a clean second build attempt.
Useful? React with 👍 / 👎.
test: retry native watcher watch steps Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
2 participants
Summary
Fixes intermittent CI failures in native watcher tests. This PR improves build event waiting and handling by introducing a timeout mechanism and retrying native watcher step changes on timeout to prevent missed rebuilds when the watcher isn't ready.
Related links
Checklist