Skip to content

fix(mf): avoid non-enhanced crash with single-item shareScope arrays#13241

Draft
cursor[bot] wants to merge 1 commit intomainfrom
cursor/critical-bug-inspection-d613
Draft

fix(mf): avoid non-enhanced crash with single-item shareScope arrays#13241
cursor[bot] wants to merge 1 commit intomainfrom
cursor/critical-bug-inspection-d613

Conversation

@cursor
Copy link
Copy Markdown

@cursor cursor Bot commented Mar 6, 2026

Fixes a critical panic in module federation container codegen when enhanced=false and shareScope is provided as a single-item array (e.g. ["default"]). Adds a regression config-case test to ensure this valid input compiles and works.

Open in Web View Automation 

Co-authored-by: hardfist <1562502418@qq.com>
@github-actions github-actions Bot added the release: bug fix release: bug related release(mr only) label Mar 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 826.2 KB 0
react-5k 2.7 MB 0
rome 984.2 KB 0
ui-components 2.3 MB 0

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

📦 Binary Size-limit

Comparing 80aea5c to fix: dup external module declarations (#13231) by Fy

❌ Size increased by 256bytes from 49.00MB to 49.00MB (⬆️0.00%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 6, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing cursor/critical-bug-inspection-d613 (80aea5c) with main (7b3b33f)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant