Skip to content

fix: sort ConcatenatedModule export keys for deterministic builds #13425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSerFeng merged 1 commit into from
Apr 29, 2026
+15 −8
Merged

fix: sort ConcatenatedModule export keys for deterministic builds #13425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions crates/rspack_core/src/concatenated_module.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1584,14 +1584,21 @@ impl Module for ConcatenatedModule {

// Define exports
if !exports_map.is_empty() {
let mut definitions = Vec::new();
for (key, value) in exports_map.iter() {
definitions.push(format!(
"\n {}: {}",
property_name(key).expect("should convert to property_name"),
runtime_template.returning_function(value, "")
));
}
let mut definitions: Vec<_> = exports_map
.iter()
.map(|(key, value)| {
(
key.clone(),
format!(
"\n {}: {}",
property_name(key).expect("should convert to property_name"),
runtime_template.returning_function(value, "")
),
)
})
.collect();
definitions.sort_by(|a, b| a.0.cmp(&b.0));
Comment thread
JSerFeng marked this conversation as resolved.
let definitions: Vec<_> = definitions.into_iter().map(|(_, s)| s).collect();

let exports_argument = self.get_exports_argument();

Expand Down
Loading