perf(module-concat): cheapen bailout reason generation#13609
Draft
LingyuCoder wants to merge 9 commits intomainfrom
Draft
perf(module-concat): cheapen bailout reason generation#13609LingyuCoder wants to merge 9 commits intomainfrom
LingyuCoder wants to merge 9 commits intomainfrom
Conversation
github-actions
Bot
added
the
team
This comment was marked as outdated.
This comment was marked as outdated.
Merging this PR will degrade performance by 5.56%
Performance Changes
Comparing 
Footnotes
|
Contributor
Rsdoctor Bundle Diff AnalysisFound 6 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
🎉 Size decreased by 9.97KB from 49.34MB to 49.33MB (⬇️0.02%) |
LingyuCoder
changed the title
github-actions
Bot
added
the
release: performance
This comment was marked as outdated.
This comment was marked as outdated.
LingyuCoder
force-pushed
the
codex/perf-module-concat-bailout-witness-impl
branch
from
f01eadd to
0be7b28
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
📝 Benchmark detail: Open
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BailoutWitnessmodeltry_to_addbailouts record one deterministic witness for missing chunks, non-module references, cross-chunk importers, unsupported syntax importers, and runtime-dependent importersWhy
module_concatenation_plugin::try_to_addwas doing extra hot-path work to build complete bailout messages, including collecting whole candidate sets, sorting them, and formatting aggregate strings. For bailout-heavy concatenation cases that overhead is unnecessary because a single sufficient witness is enough to explain the bailout.Impact
Validation
cargo fmt --all --checkcargo lintpnpm run build:cli:devpnpm run test:rspnpm run test -t "side-effects-optimization"pnpm run test -t "scope-hoisting-multi"Notes
Checked: ... rust@create_concatenate_modulebecause CodSpeed reported an unknown environment, so no strict local numeric before/after claim is included herepnpm run test:unitwas not stable locally: repeated runs failed in different places (builtin-swc-loadertimeout,Serial.test.jsworker exit,Config.part1.test.jsafterAll timeout), which looks more like suite/harness flakiness than a stable regression from this Rust-only change