From 511579750ba5a22deaf7bbc090992ba68051ac47 Mon Sep 17 00:00:00 2001 From: neverland Date: Tue, 14 Apr 2026 13:49:44 +0800 Subject: [PATCH] chore: remove stale ts-node config remnants --- .../tests/build/config/config.test.ts | 42 ------------------- .../build/config/ts-node-register/main.ts | 1 - .../config/ts-node-register/rspack.config.ts | 19 --------- .../config/ts-node-register/tsconfig.json | 12 ------ packages/rspack/tsconfig.browser.json | 5 +-- tests/bench/fixtures/ts-react/tsconfig.json | 7 +--- tests/e2e/tsconfig.json | 3 -- 7 files changed, 2 insertions(+), 87 deletions(-) delete mode 100644 packages/rspack-cli/tests/build/config/ts-node-register/main.ts delete mode 100644 packages/rspack-cli/tests/build/config/ts-node-register/rspack.config.ts delete mode 100644 packages/rspack-cli/tests/build/config/ts-node-register/tsconfig.json diff --git a/packages/rspack-cli/tests/build/config/config.test.ts b/packages/rspack-cli/tests/build/config/config.test.ts index 0ff97a7ea1e7..09914cd7fbc6 100644 --- a/packages/rspack-cli/tests/build/config/config.test.ts +++ b/packages/rspack-cli/tests/build/config/config.test.ts @@ -337,46 +337,4 @@ describe('rspack cli', () => { ).resolves.toMatch(/Main monorepo file/); }); }); - - describe('should keep builtin config loader semantics', () => { - const cwd = resolve(__dirname, './ts-node-register'); - it("builtin config loader can't handle declare const enum", async () => { - const { exitCode, stdout, stderr } = await run( - cwd, - ['-c', 'rspack.config.ts'], - { - nodeOptions: [], - }, - ); - expect(stdout).toBeFalsy(); - expect(stderr).toBeTruthy(); - expect(stderr).toMatch(/ReferenceError: JSB is not defined/); - expect(exitCode).toBe(1); - }); - }); - - // describe("loose-unrecognized-keys (default)", () => { - // const cwd = resolve(__dirname, "./loose-unrecognized-keys"); - // it.concurrent("should report unrecognized keys", async () => { - // const { stderr, exitCode } = await run(cwd, []); - // expect(stderr).toMatchInlineSnapshot(` - // "Configuration error: - // - Unrecognized key(s) in object: '_additionalProperty'" - // `); - // expect(stderr).not.toMatch("ValidationError"); - // expect(exitCode).toBe(0); - // }); - // }); - - // describe("loose-unrecognized-keys 2 (default)", () => { - // const cwd = resolve(__dirname, "./loose-unrecognized-keys-other-error"); - // it.concurrent("should fail on other error", async () => { - // const { stderr, exitCode } = await run(cwd, []); - // expect(stderr).toMatch("ValidationError"); - // expect(stderr).toMatch( - // `The provided value "./context" must be an absolute path. at \"context"` - // ); - // expect(exitCode).toBe(1); - // }); - // }); }); diff --git a/packages/rspack-cli/tests/build/config/ts-node-register/main.ts b/packages/rspack-cli/tests/build/config/ts-node-register/main.ts deleted file mode 100644 index 17e15c34db8b..000000000000 --- a/packages/rspack-cli/tests/build/config/ts-node-register/main.ts +++ /dev/null @@ -1 +0,0 @@ -console.log(`Main ts-node-register file: ${ANSWER}`); diff --git a/packages/rspack-cli/tests/build/config/ts-node-register/rspack.config.ts b/packages/rspack-cli/tests/build/config/ts-node-register/rspack.config.ts deleted file mode 100644 index db4157100d7f..000000000000 --- a/packages/rspack-cli/tests/build/config/ts-node-register/rspack.config.ts +++ /dev/null @@ -1,19 +0,0 @@ -import path from 'path'; -import rspack from '@rspack/core'; -declare const enum JSB { - SECRET = 42, -} -export default { - mode: 'production', - entry: path.resolve(__dirname, 'main.ts'), - - output: { - path: path.resolve(__dirname, 'dist'), - filename: 'node-register.bundle.js', - }, - plugins: [ - new rspack.DefinePlugin({ - ANSWER: JSB.SECRET, - }), - ], -}; diff --git a/packages/rspack-cli/tests/build/config/ts-node-register/tsconfig.json b/packages/rspack-cli/tests/build/config/ts-node-register/tsconfig.json deleted file mode 100644 index d55be2d11fae..000000000000 --- a/packages/rspack-cli/tests/build/config/ts-node-register/tsconfig.json +++ /dev/null @@ -1,12 +0,0 @@ -{ - "compilerOptions": { - "rootDir": ".", - "target": "ESNext", - "module": "commonjs", - "noEmit": true, - "moduleResolution": "node", - "esModuleInterop": true, - "types": ["node", "./namespace.d.ts"] - }, - "include": ["**/*.ts", "**/*.js"] -} diff --git a/packages/rspack/tsconfig.browser.json b/packages/rspack/tsconfig.browser.json index a5e3b74b8fd9..827b34c8ca7c 100644 --- a/packages/rspack/tsconfig.browser.json +++ b/packages/rspack/tsconfig.browser.json @@ -12,8 +12,5 @@ "declarationMap": false }, "include": ["src", "src/**/*.json"], - "exclude": ["src/container/default.runtime.js"], - "ts-node": { - "transpileOnly": true - } + "exclude": ["src/container/default.runtime.js"] } diff --git a/tests/bench/fixtures/ts-react/tsconfig.json b/tests/bench/fixtures/ts-react/tsconfig.json index 1222cf3e0743..f72462a87264 100644 --- a/tests/bench/fixtures/ts-react/tsconfig.json +++ b/tests/bench/fixtures/ts-react/tsconfig.json @@ -11,10 +11,5 @@ "useDefineForClassFields": true, "allowImportingTsExtensions": true }, - "include": ["src"], - "ts-node": { - "compilerOptions": { - "module": "CommonJS" - } - } + "include": ["src"] } diff --git a/tests/e2e/tsconfig.json b/tests/e2e/tsconfig.json index 342bdae564ea..86f6fd177c91 100644 --- a/tests/e2e/tsconfig.json +++ b/tests/e2e/tsconfig.json @@ -8,8 +8,5 @@ "@/*": ["./*"] }, "checkJs": false - }, - "ts-node": { - "transpileOnly": true } }