Skip to content

chore: remove stale ts-node config remnants #13698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Apr 17, 2026
Merged

chore: remove stale ts-node config remnants #13698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions packages/rspack-cli/tests/build/config/config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,46 +337,4 @@ describe('rspack cli', () => {
).resolves.toMatch(/Main monorepo file/);
});
});

describe('should keep builtin config loader semantics', () => {
const cwd = resolve(__dirname, './ts-node-register');
it("builtin config loader can't handle declare const enum", async () => {
const { exitCode, stdout, stderr } = await run(
cwd,
['-c', 'rspack.config.ts'],
{
nodeOptions: [],
},
);
expect(stdout).toBeFalsy();
expect(stderr).toBeTruthy();
expect(stderr).toMatch(/ReferenceError: JSB is not defined/);
expect(exitCode).toBe(1);
});
});

// describe("loose-unrecognized-keys (default)", () => {
// const cwd = resolve(__dirname, "./loose-unrecognized-keys");
// it.concurrent("should report unrecognized keys", async () => {
// const { stderr, exitCode } = await run(cwd, []);
// expect(stderr).toMatchInlineSnapshot(`
// "Configuration error:
// - Unrecognized key(s) in object: '_additionalProperty'"
// `);
// expect(stderr).not.toMatch("ValidationError");
// expect(exitCode).toBe(0);
// });
// });

// describe("loose-unrecognized-keys 2 (default)", () => {
// const cwd = resolve(__dirname, "./loose-unrecognized-keys-other-error");
// it.concurrent("should fail on other error", async () => {
// const { stderr, exitCode } = await run(cwd, []);
// expect(stderr).toMatch("ValidationError");
// expect(stderr).toMatch(
// `The provided value "./context" must be an absolute path. at \"context"`
// );
// expect(exitCode).toBe(1);
// });
// });
});
1 change: 0 additions & 1 deletion packages/rspack-cli/tests/build/config/ts-node-register/main.ts
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions packages/rspack-cli/tests/build/config/ts-node-register/rspack.config.ts
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions packages/rspack-cli/tests/build/config/ts-node-register/tsconfig.json
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions packages/rspack/tsconfig.browser.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,5 @@
"declarationMap": false
},
"include": ["src", "src/**/*.json"],
"exclude": ["src/container/default.runtime.js"],
"ts-node": {
"transpileOnly": true
}
"exclude": ["src/container/default.runtime.js"]
}
7 changes: 1 addition & 6 deletions tests/bench/fixtures/ts-react/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,5 @@
"useDefineForClassFields": true,
"allowImportingTsExtensions": true
},
"include": ["src"],
"ts-node": {
"compilerOptions": {
"module": "CommonJS"
}
}
"include": ["src"]
}
3 changes: 0 additions & 3 deletions tests/e2e/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,5 @@
"@/*": ["./*"]
},
"checkJs": false
},
"ts-node": {
"transpileOnly": true
}
}
Loading