Skip to content

perf(deps): unify duplicate Rust dependencies to reduce binary size#14012

Open
intellild wants to merge 3 commits into
mainfrom
codex/unify-icu-dependencies
Open

perf(deps): unify duplicate Rust dependencies to reduce binary size#14012
intellild wants to merge 3 commits into
mainfrom
codex/unify-icu-dependencies

Conversation

@intellild
Copy link
Copy Markdown
Contributor

@intellild intellild commented May 12, 2026

Summary

  • update the lockfile so the url -> idna -> idna_adapter dependency path uses idna_adapter 1.2.1
  • remove the duplicate ICU 1.5.x dependency graph from Cargo.lock
  • keep ICU-related crates unified on the existing 2.1.x graph used by SWC regexp support
  • update the workspace wasmparser dependency from 0.222.0 to 0.235.0
  • remove the duplicate wasmparser 0.222.0 entry from Cargo.lock
  • remove the now-unneeded icu_normalizer and wasmparser duplicate-dependency skips from deny.toml

Root Cause

idna_adapter 1.2.0 still resolved to icu_normalizer/icu_properties 1.5.x, while swc_ecma_compat_regexp already used icu_properties 2.1.x. Updating idna_adapter allowed Cargo to resolve both paths through the same ICU 2.1.x family.

rspack_plugin_wasm still used workspace wasmparser 0.222.0, while the Wasmtime dependency graph already used 0.235.0. Updating the workspace dependency lets Cargo use the same wasmparser version for both paths, so the cargo-deny skip is no longer needed.

Validation

  • cargo tree -i icu_provider shows only icu_provider v2.1.1
  • cargo tree -d | grep -E "^icu_| icu_|^idna_adapter| idna_adapter"
  • cargo check -p rspack_javascript_compiler --locked
  • cargo check -p rspack_plugin_wasm --locked
  • cargo tree -d --locked --all-features --target all no longer reports duplicate wasmparser

Not run: cargo deny check bans, because cargo-deny is not installed in this environment.


by OpenAI Codex

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

📦 Binary Size-limit

Comparing bf2cff8 to perf: cache reserved name atom set (#14014) by harpsealjs

🎉 Size decreased by 24.00KB from 61.93MB to 61.91MB (⬇️0.04%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Rsdoctor Bundle Diff Analysis

Found 6 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
popular-libs 1.7 MB 0
react-10k 5.7 MB 0
react-1k 826.3 KB 0
rome 1.6 MB 0
react-5k 2.7 MB 0
ui-components 4.8 MB 0

Generated by Rsdoctor GitHub Action

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 12, 2026

Merging this PR will not alter performance

✅ 34 untouched benchmarks
⏩ 25 skipped benchmarks1


Comparing codex/unify-icu-dependencies (bf2cff8) with main (dfcccd6)

Open in CodSpeed

Footnotes

  1. 25 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@intellild intellild force-pushed the codex/unify-icu-dependencies branch from 90e695a to 8cf0083 Compare May 12, 2026 08:06
@intellild intellild changed the title [codex] chore: unify icu dependencies perf: unify icu dependencies May 12, 2026
@github-actions github-actions Bot added the release: performance release: performance related release(mr only) label May 12, 2026
@intellild intellild marked this pull request as ready for review May 12, 2026 08:52
@intellild intellild changed the title perf: unify icu dependencies chore(deps): unify duplicate Rust dependencies May 12, 2026
@intellild intellild changed the title chore(deps): unify duplicate Rust dependencies perf(deps): unify duplicate Rust dependencies to reduce binary size May 12, 2026
@intellild intellild requested a review from hardfist May 12, 2026 10:49
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 12, 2026

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: bf2cff8
Status: ✅  Deploy successful!
Preview URL: https://a577e258.rspack-v2.pages.dev
Branch Preview URL: https://codex-unify-icu-dependencies.rspack-v2.pages.dev

View logs

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

📝 Rspack Ecosystem CI: Open

suite result
rsbuild ✅ success
modernjs ❌ failure
rslib ✅ success
rsbuild-rsc-plugin ✅ success
rspress ✅ success
examples ✅ success
lynx-stack ❌ failure
rsdoctor ✅ success
plugin ✅ success
devserver ✅ success
rstest ✅ success

@intellild
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: performance release: performance related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant