perf(deps): unify duplicate Rust dependencies to reduce binary size#14012
perf(deps): unify duplicate Rust dependencies to reduce binary size#14012intellild wants to merge 3 commits into
Conversation
📦 Binary Size-limit
🎉 Size decreased by 24.00KB from 61.93MB to 61.91MB (⬇️0.04%) |
Rsdoctor Bundle Diff AnalysisFound 6 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Merging this PR will not alter performance
Comparing Footnotes
|
90e695a to
8cf0083
Compare
Deploying rspack with
|
| Latest commit: |
bf2cff8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a577e258.rspack-v2.pages.dev |
| Branch Preview URL: | https://codex-unify-icu-dependencies.rspack-v2.pages.dev |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
url -> idna -> idna_adapterdependency path usesidna_adapter1.2.1Cargo.lockwasmparserdependency from 0.222.0 to 0.235.0wasmparser0.222.0 entry fromCargo.lockicu_normalizerandwasmparserduplicate-dependency skips fromdeny.tomlRoot Cause
idna_adapter1.2.0 still resolved toicu_normalizer/icu_properties1.5.x, whileswc_ecma_compat_regexpalready usedicu_properties2.1.x. Updatingidna_adapterallowed Cargo to resolve both paths through the same ICU 2.1.x family.rspack_plugin_wasmstill used workspacewasmparser0.222.0, while the Wasmtime dependency graph already used 0.235.0. Updating the workspace dependency lets Cargo use the samewasmparserversion for both paths, so the cargo-deny skip is no longer needed.Validation
cargo tree -i icu_providershows onlyicu_provider v2.1.1cargo tree -d | grep -E "^icu_| icu_|^idna_adapter| idna_adapter"cargo check -p rspack_javascript_compiler --lockedcargo check -p rspack_plugin_wasm --lockedcargo tree -d --locked --all-features --target allno longer reports duplicatewasmparserNot run:
cargo deny check bans, becausecargo-denyis not installed in this environment.by OpenAI Codex