perf: verify rstackjs/rspack-resolver#275 (std::fs in FileSystemOs) via CodSpeed#14337
perf: verify rstackjs/rspack-resolver#275 (std::fs in FileSystemOs) via CodSpeed#14337stormslowly wants to merge 1 commit into
Conversation
…eed verification
📦 Binary Size-limit
🎉 Size decreased by 12.00KB from 62.60MB to 62.59MB (⬇️0.02%) |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 2 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 popular-libsPath:
📦 Download Diff Report: popular-libs Bundle Diff 📁 ui-componentsPath:
📦 Download Diff Report: ui-components Bundle Diff 🤖 AI Degradation Analysis (Click to expand)📁 popular-libs📊 Size ChangesNo meaningful change detected; table skipped per constraints. Total bundle size decreased negligibly by 26 bytes (1,806,629 → 1,806,603). Initial JS chunk also decreased by 26 bytes (1,806,340 → 1,806,314). 🔍 Root Cause Analysis
|
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | js@collect imported identifiers |
222.4 µs | 228.3 µs | -2.6% |
| ⚡ | Simulation | js@external getResolve |
1.5 ms | 1.4 ms | +5.3% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/verify-resolver-275-std-fs (171e2e3) with main (b04d9f4)
Footnotes
-
40 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Verification result: no measurable impact on rspack buildsLocal callgrind (Linux x86_64, CodSpeed simulation flags, Why the resolver-side -23% does not transferrspack never instantiates the resolver's default
Additionally, callgrind shows resolver fs machinery ( Conclusion: rstackjs/rspack-resolver#275 is worth landing for resolver-standalone users and the napi resolve API, but brings no measurable gain to rspack core builds. Closing this verification PR is fine once recorded. |
Why
Verification PR for rstackjs/rspack-resolver#275, which replaces
tokio::fswithstd::fsinFileSystemOsand showed -22.9% aggregate estimated cycles on the resolver's own benches.This PR patches
rspack_resolverto that branch's head (b9eb9b8) via[patch.crates-io]so rspack's CodSpeed benches measure the end-to-end impact inside rspack builds.Not intended to be merged — once verified, the resolver PR should land and be released, then rspack bumps the version normally.