feat: support import.meta.env by intellild · Pull Request #14483 · web-infra-dev/rspack

intellild · 2026-06-18T05:08:42Z

Summary

Support import.meta.env
Adds process.env destructuring support to DefinePlugin.
Disabled by default since it breaks ecosystem ci. I will update ecosystem then target to enable it by default in 2.2.0

Example use case

This lets applications and libraries that read feature flags or build-time values from import.meta.env compile under Rspack when experiments.env is enabled:

const { DefinePlugin, EnvironmentPlugin } = require("@rspack/core");

module.exports = {
  experiments: {
    env: true,
  },
  plugins: [
    new EnvironmentPlugin({
      FEATURE_FLAG: "off",
    }),
    new DefinePlugin({
      "import.meta.env.APP_VERSION": JSON.stringify("1.0.0"),
    }),
  ],
};

if (import.meta.env.FEATURE_FLAG === "on") {
  enableFeature();
}

console.log(import.meta.env.APP_VERSION);

Checklist

Tests updated (or not required).
Documentation updated (or not required).

github-actions · 2026-06-18T05:16:44Z

📦 Binary Size-limit

Comparing 6367856 to fix: preserve createRequire().resolve with literal import.meta.url when requireResolve is disabled (#14783) by Fy

❌ Size increased by 32.00KB from 66.58MB to 66.61MB (⬆️0.05%)

codspeed-hq · 2026-06-18T05:32:29Z

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 47 skipped benchmarks¹

_{Comparing codex/import-meta-env-runtime (6367856) with main (b8e3594)}

47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

cloudflare-workers-and-pages · 2026-06-22T07:36:34Z

Deploying rspack with Cloudflare Pages

Latest commit:	`0866f75`
Status:	✅ Deploy successful!
Preview URL:	https://61406090.rspack-v2.pages.dev
Branch Preview URL:	https://codex-import-meta-env-runtim.rspack-v2.pages.dev

View logs

github-actions · 2026-06-23T11:17:12Z

📝 Rspack Ecosystem CI: Open

suite	result

intellild · 2026-06-29T10:59:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d243ca29b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

intellild · 2026-06-29T11:18:37Z

@codex review

github-actions · 2026-06-29T11:25:04Z

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary

Project	Total Size	Gzip Size	Change	Gzip Change
popular-libs	1.7 MB	551.8 KB	-	-
react-10k	5.6 MB	1.3 MB	-	-
react-1k	823.1 KB	217.0 KB	-	-
react-5k	2.7 MB	663.8 KB	-	-
ui-components	4.9 MB	1.4 MB	-	-

📋 Detailed Reports (Click to expand)

📁 popular-libs

Path: ../build-tools-performance/cases/popular-libs/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric	Current	Baseline	Change
📊 Total Size	1.7 MB	-	-
🗜️ Gzip Size	551.8 KB	-	-
📄 JavaScript	1.7 MB	-	-
🎨 CSS	0 B	-	-
🌐 HTML	289.0 B	-	-
📁 Other Assets	0 B	-	-

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric	Current	Baseline	Change
📊 Total Size	5.6 MB	-	-
🗜️ Gzip Size	1.3 MB	-	-
📄 JavaScript	5.6 MB	-	-
🎨 CSS	21.0 B	-	-
🌐 HTML	328.0 B	-	-
📁 Other Assets	0 B	-	-

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric	Current	Baseline	Change
📊 Total Size	823.1 KB	-	-
🗜️ Gzip Size	217.0 KB	-	-
📄 JavaScript	822.7 KB	-	-
🎨 CSS	0 B	-	-
🌐 HTML	328.0 B	-	-
📁 Other Assets	0 B	-	-

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric	Current	Baseline	Change
📊 Total Size	2.7 MB	-	-
🗜️ Gzip Size	663.8 KB	-	-
📄 JavaScript	2.7 MB	-	-
🎨 CSS	21.0 B	-	-
🌐 HTML	328.0 B	-	-
📁 Other Assets	0 B	-	-

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric	Current	Baseline	Change
📊 Total Size	4.9 MB	-	-
🗜️ Gzip Size	1.4 MB	-	-
📄 JavaScript	4.8 MB	-	-
🎨 CSS	112.1 KB	-	-
🌐 HTML	328.0 B	-	-
📁 Other Assets	0 B	-	-

Generated by Rsdoctor GitHub Action

intellild · 2026-06-29T13:33:35Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 83e6b92c46

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

intellild · 2026-06-30T03:19:13Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 06ace2ec8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

intellild · 2026-06-30T05:13:21Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45803a716a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-06-30T06:00:56Z

📝 Rspack Ecosystem CI: Open

suite	result
rslib	✅ success
rsbuild-rsc-plugin	✅ success
modernjs	✅ success
rsbuild	✅ success
rspress	✅ success
plugin	✅ success
examples	✅ success
rstest	✅ success
devserver	✅ success
lynx-stack	✅ success
rsdoctor	✅ success

intellild · 2026-07-08T02:12:03Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd34a2ea63

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

intellild · 2026-07-08T05:42:15Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 176bef475a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

intellild · 2026-07-13T11:00:24Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22e1b87059

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

intellild · 2026-07-13T11:27:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 053b873d3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

intellild · 2026-07-13T12:37:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d3591040f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

intellild · 2026-07-14T11:13:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b723478f10

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

intellild · 2026-07-14T11:57:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04964da347

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

intellild · 2026-07-15T13:02:44Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6367856642

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-15T13:14:19Z

+  if !child.is_object() {
+    *child = Value::Object(Map::new());


Avoid overwriting scalar env values with nested keys

When a config defines both a scalar key like import.meta.env.FOO and a nested key such as import.meta.env.FOO.BAR in the same or a later DefinePlugin, this branch replaces the already-collected scalar with a new object, so import.meta.env.FOO changes from the configured scalar to { BAR: ... } without a conflict. The surrounding merge logic otherwise keeps existing definitions on conflicts, so nested insertion should not overwrite a non-object child silently.

Useful? React with 👍 / 👎.

intellild changed the title ~~feat: support import.meta.env and env merging~~ feat: support import.meta.env, DotenvPlugin and env merging Jun 18, 2026

intellild changed the title ~~feat: support import.meta.env, DotenvPlugin and env merging~~ feat: support import.meta.env Jun 22, 2026

intellild force-pushed the codex/import-meta-env-runtime branch 3 times, most recently from 110ae08 to 28ccd5d Compare June 22, 2026 07:36

This comment was marked as outdated.

Sign in to view

intellild mentioned this pull request Jun 23, 2026

import.meta Behavior: Standardizing behavior across bundlers and runtimes openjs-foundation/bundler-collab-space#8

Open

intellild force-pushed the codex/import-meta-env-runtime branch from 37b92e6 to 3c3eaac Compare June 24, 2026 03:46

This comment was marked as outdated.

Sign in to view

intellild marked this pull request as ready for review June 29, 2026 03:36

intellild requested a review from hardfist as a code owner June 29, 2026 03:36

intellild force-pushed the codex/import-meta-env-runtime branch from 3c3eaac to f7460ee Compare June 29, 2026 07:21

intellild marked this pull request as draft June 29, 2026 07:26

chatgpt-codex-connector Bot reviewed Jun 29, 2026

View reviewed changes

Comment thread crates/rspack_plugin_javascript/src/parser_plugin/define_plugin/walk_data.rs Outdated

Comment thread crates/rspack_plugin_javascript/src/parser_plugin/define_plugin/mod.rs Outdated

chatgpt-codex-connector Bot reviewed Jun 29, 2026

View reviewed changes

Comment thread crates/rspack_plugin_javascript/src/parser_plugin/import_meta_plugin.rs Outdated

chatgpt-codex-connector Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread crates/rspack_plugin_javascript/src/parser_plugin/import_meta_plugin.rs Outdated

chatgpt-codex-connector Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread crates/rspack_plugin_javascript/src/parser_plugin/define_plugin/walk_data.rs Outdated

intellild force-pushed the codex/import-meta-env-runtime branch 2 times, most recently from 3dce4b6 to dd34a2e Compare July 7, 2026 08:25

intellild marked this pull request as ready for review July 7, 2026 11:19

intellild requested a review from LingyuCoder July 8, 2026 02:11

chatgpt-codex-connector Bot reviewed Jul 8, 2026

View reviewed changes

Comment thread packages/rspack/src/builtin-plugin/DefinePlugin.ts Outdated

intellild marked this pull request as draft July 8, 2026 02:23

intellild force-pushed the codex/import-meta-env-runtime branch from a2facf0 to 176bef4 Compare July 8, 2026 03:58

chatgpt-codex-connector Bot reviewed Jul 8, 2026

View reviewed changes

Comment thread crates/rspack_plugin_javascript/src/parser_plugin/import_meta_plugin.rs Outdated

intellild force-pushed the codex/import-meta-env-runtime branch from 176bef4 to 1adb66f Compare July 13, 2026 05:49

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread website/docs/en/plugins/webpack/define-plugin.mdx Outdated

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread packages/rspack/src/lib/EnvironmentPlugin.ts

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread crates/rspack_plugin_javascript/src/parser_plugin/define_plugin/parser.rs

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/rspack_plugin_javascript/src/parser_plugin/define_plugin/parser.rs

feat: support import.meta.env

04964da

intellild force-pushed the codex/import-meta-env-runtime branch from b723478 to 04964da Compare July 14, 2026 11:43

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/rspack/src/builder/mod.rs

intellild added 7 commits July 15, 2026 03:05

fix: handle import.meta.env edge cases

afbc68f

fix: handle structured import.meta.env definitions

63b40cd

fix: align import.meta.env with DefinePlugin

62af651

fix: refine import.meta.env definitions

63b8d06

fix: remove undefined import.meta.env warnings

68e060b

docs: clarify import.meta.env behavior

0866f75

test: remove stale import.meta.env warning expectation

6367856

chatgpt-codex-connector Bot reviewed Jul 15, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

intellild commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Example use case

Related links

Checklist

Uh oh!

github-actions Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Binary Size-limit

Uh oh!

codspeed-hq Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

cloudflare-workers-and-pages Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rspack with Cloudflare Pages

Uh oh!

This comment was marked as outdated.

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

intellild commented Jun 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

intellild commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rsdoctor Bundle Diff Analysis

📁 popular-libs

📁 react-10k

📁 react-1k

📁 react-5k

📁 ui-components

Uh oh!

intellild commented Jun 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

intellild commented Jun 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

intellild commented Jun 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

intellild commented Jul 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

intellild commented Jul 8, 2026

Uh oh!

intellild commented Jun 18, 2026 •

edited

Loading

github-actions Bot commented Jun 18, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 18, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 29, 2026 •

edited

Loading

github-actions Bot commented Jun 30, 2026 •

edited

Loading