Skip to content

fix: recreate persistent cache directories during save#14725

Draft
hardfist wants to merge 1 commit into
mainfrom
codex/fix-persistent-cache-watch-delete
Draft

fix: recreate persistent cache directories during save#14725
hardfist wants to merge 1 commit into
mainfrom
codex/fix-persistent-cache-watch-delete

Conversation

@hardfist

@hardfist hardfist commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Recreate persistent cache destination directories before moving staged files so watch-mode saves can write packs after the cache directory is removed.
  • Add a JS watch regression that deletes the persistent cache directory between rebuilds and verifies pack files are written again.

Related links

Closes #14723

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@codspeed-hq

codspeed-hq Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 47 skipped benchmarks1


Comparing codex/fix-persistent-cache-watch-delete (407e6db) with main (be555f9)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Persistent cache stops writing in watch mode after cache directory is removed

1 participant