feat: add persistent cache for module codegen#14731
Conversation
📦 Binary Size-limit
❌ Size increased by 129.00KB from 66.53MB to 66.66MB (⬆️0.19%) |
Merging this PR will degrade performance by 12.13%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
bb2b524 to
9bbce32
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 867abccd85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[cacheable(with=AsOption<Unsupported>)] | ||
| pub concatenation_scope: Option<ConcatenationScope>, |
There was a problem hiding this comment.
Avoid poisoning codegen cache for concatenation scopes
Marking concatenation_scope as AsOption<Unsupported> makes serialization fail whenever it is Some. The ESM library concatenation-scope hook returns Some(ConcatenationScope) for scope-hoisted modules and parser/generator stores it on CodeGenerationResult, so ModulesCodegenOccasion::save will fail encoding and reset the entire modules-codegen occasion for those builds. This silently disables the new persistent codegen cache in that configuration; serialize the scope or skip only those entries instead of failing the whole artifact.
Useful? React with 👍 / 👎.
Summary
Related links
Checklist