perf: deduplicate repeated dynamic reexport code#14748
Draft
JSerFeng wants to merge 1 commit into
Draft
Conversation
Contributor
📦 Binary Size-limit
❌ Size increased by 20.00KB from 66.48MB to 66.50MB (⬆️0.03%) |
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
export *code.Dynamic star reexports currently emit the same getter collection loop for every dependency. This change moves that loop into
__webpack_require__.reonly when the helper cost is amortized, while keeping the low-cardinality output unchanged.For 16 dynamic reexports in a production build with the SWC minimizer, compared with a mechanical old-inline baseline:
The helper preserves source enumeration order, single and multiple exclusion handling, environment-specific getter capture, and the existing define-after-collection behavior.
Related links
N/A
Checklist