fix: preserve lazy compilation invalidation provenance by ScriptedAlchemy · Pull Request #14753 · web-infra-dev/rspack

ScriptedAlchemy · 2026-07-11T02:27:16Z

Summary

Records explicit lazy invalidations separately from normal invalidations and snapshots that provenance at each watch-cycle boundary. MultiCompiler resumes already-recorded child invalidations without reclassifying them as normal, lazy middleware tags only the activated child compiler, and entrypoint stats use snapshot-safe chunk-group asset data.

Tests

Rspack package build passed.
Focused watcher regression: 401 passed.
Focused MultiCompiler dependency/provenance regression: 401 passed.
E2E-tested canary: @rspack-canary/core@2.1.4-canary-447f6a85-20260711031950. Latest successful canary: @rspack-canary/core@2.1.4-canary-a938a49e-20260711045630.
Cross-repository Playwright route activation passed with linked previews.

Checklist

Tests updated.
Documentation updated (not required).

Copilot

Pull request overview

This PR improves watch-mode correctness around lazy compilation by tracking whether an invalidation was explicitly triggered by lazy compilation middleware vs. a “normal” invalidation, and by snapshotting that provenance at each watch-cycle boundary so it can be consumed reliably by hooks/stats.

Changes:

Track “lazy” vs “normal” invalidation provenance across invalidations and snapshot it per watch cycle in Watching.
Update lazy compilation dev-server middleware to tag invalidations on the activated child compiler in multi-compiler mode.
Adjust entrypoint auto-detection in stats to rely on chunk-group asset data (snapshot-safe) rather than Chunk.files.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
tests/rspack-test/compilerCases/watching.js	Adds a regression test asserting lazy invalidation provenance is snapshotted per watch cycle.
packages/rspack/src/Watching.ts	Records invalidation provenance via internal `Symbol.for(...)` flags and snapshots it at the start of each watch compilation.
packages/rspack/src/stats/DefaultStatsFactoryPlugin.ts	Switches entrypoint simplification heuristics to use chunk-group assets/auxiliaryAssets rather than chunk file sets.
packages/rspack/src/builtin-plugin/lazy-compilation/middleware.ts	Ensures only the activated child compiler is tagged as a lazy invalidation source in multi-compiler middleware.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-07-11T02:30:49Z

📦 Binary Size-limit

Comparing b563d17 to fix: respect RSPACK_BINDING in loader workers (#14775) by hardfist

❌ Size increased by 12.00KB from 66.51MB to 66.52MB (⬆️0.02%)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7e9b6712c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codspeed-hq · 2026-07-11T03:03:46Z

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 47 skipped benchmarks¹

_{Comparing codex/lazy-compilation-watch-provenance (b563d17) with main (03465ca)}

47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 447f6a8585

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a938a49ea3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 457c779f94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3611f8a33c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a3a2232cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bfceff3ebc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…n-watch-provenance # Conflicts: # tests/rspack-test/hotCases/sharing/share-plugin/__snapshots__/web/1.snap.txt

cloudflare-workers-and-pages · 2026-07-14T00:14:48Z

Deploying rspack with Cloudflare Pages

Latest commit:	`3c20a6b`
Status:	✅ Deploy successful!
Preview URL:	https://09c9267e.rspack-v2.pages.dev
Branch Preview URL:	https://codex-lazy-compilation-watch.rspack-v2.pages.dev

View logs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c20a6bb78

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…n-watch-provenance

fix: preserve lazy compilation invalidation provenance

c7e9b67

ScriptedAlchemy requested a review from hardfist as a code owner July 11, 2026 02:27

Copilot AI review requested due to automatic review settings July 11, 2026 02:27

Copilot started reviewing on behalf of ScriptedAlchemy July 11, 2026 02:27 View session

Copilot AI reviewed Jul 11, 2026

View reviewed changes

Comment thread packages/rspack/src/stats/DefaultStatsFactoryPlugin.ts Outdated

chatgpt-codex-connector Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread packages/rspack/src/Watching.ts Outdated

This was referenced Jul 11, 2026

fix(core): preserve lazy compilation HMR state web-infra-dev/rsbuild#8091

Open

feat: add safe lazy route compilation rstackjs/rsbuild-plugin-react-router#97

Closed

ScriptedAlchemy added 2 commits July 11, 2026 02:43

test: sequence lazy watch invalidations

3b877f8

fix: preserve invalidation kind through multi compiler scheduling

447f6a8

chatgpt-codex-connector Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread packages/rspack/src/MultiCompiler.ts Outdated

ScriptedAlchemy added 2 commits July 11, 2026 03:25

fix: notify invalid hooks when resuming multi compiler

5156531

fix: classify file-backed watch invalidations

a938a49

chatgpt-codex-connector Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread packages/rspack/src/Watching.ts Outdated

fix: classify paused watcher changes

457c779

chatgpt-codex-connector Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread packages/rspack/src/Watching.ts Outdated

ScriptedAlchemy added 3 commits July 11, 2026 21:21

refactor: centralize watch invalidation state

54a235f

fix: retain pending native watcher changes

0bfb229

test: await native watcher initialization

3611f8a

chatgpt-codex-connector Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread packages/rspack/src/NativeWatchFileSystem.ts Outdated

ScriptedAlchemy added 2 commits July 11, 2026 21:49

test: remove platform-specific watcher injection

7430b8f

fix: purge pending native watcher changes

9a3a223

chatgpt-codex-connector Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread packages/rspack/src/builtin-plugin/lazy-compilation/middleware.ts Outdated

fix: preserve multi-compiler lazy provenance

bfceff3

chatgpt-codex-connector Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread packages/rspack/src/NativeWatchFileSystem.ts Outdated

fix: consume aggregated native watcher changes

435729c

ScriptedAlchemy mentioned this pull request Jul 13, 2026

test: cover lazy compilation hydration workaround rstackjs/rsbuild-plugin-react-router#99

Closed

fix: type lazy compilation invalidation provenance

7f70b19

ScriptedAlchemy added 4 commits July 13, 2026 23:18

fix: atomically drain native watcher events

55bcf0c

fix: preserve disposed factories during HMR apply

f4dfd77

Merge remote-tracking branch 'origin/main' into codex/lazy-compilatio…

a72c09b

…n-watch-provenance # Conflicts: # tests/rspack-test/hotCases/sharing/share-plugin/__snapshots__/web/1.snap.txt

refactor: simplify lazy HMR event handling

3c20a6b

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/rspack_plugin_runtime/src/runtime_module/runtime/javascript_hot_module_replacement.ejs

Comment thread packages/rspack/src/MultiCompiler.ts Outdated

ScriptedAlchemy added 4 commits July 14, 2026 00:31

test: avoid watcher path allocation

a10dafe

fix: preserve lazy HMR invalidation semantics

9f74886

test: update HMR runtime snapshots

89e9ecd

Merge remote-tracking branch 'origin/main' into codex/lazy-compilatio…

b563d17

…n-watch-provenance

Uh oh!

Uh oh!

Conversation

ScriptedAlchemy commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related links

Tests

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Binary Size-limit

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codspeed-hq Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cloudflare-workers-and-pages Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rspack with Cloudflare Pages

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ScriptedAlchemy commented Jul 11, 2026 •

edited

Loading

github-actions Bot commented Jul 11, 2026 •

edited

Loading

codspeed-hq Bot commented Jul 11, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Jul 14, 2026 •

edited

Loading