perf: parallelize code splitting chunk group walks#14759
Draft
JSerFeng wants to merge 1 commit into
Draft
Conversation
Contributor
|
⏳ Triggered benchmark: Open |
Contributor
📦 Binary Size-limit
❌ Size increased by 56.00KB from 66.50MB to 66.56MB (⬆️0.08%) |
Contributor
Merging this PR will improve performance by 2.27%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RSPACK_EXPERIMENTAL_PARALLEL_CODE_SPLITTING=0as a process-level fallbackPerformance
The wide Rspack benchmark improved from 89.948 ms to 71.654 ms (-20.3%). In the Arco Pro production benchmark,
buildChunkGraph.process queueimproved from 2.616 ms to 1.967 ms (-24.8%), while total build time remained effectively unchanged because this stage is a small part of the build.A 1-thread control measured 71.608 ms versus 71.654 ms with 8 threads, so the measured gain currently comes primarily from batched commits and avoided repeated work; these workloads do not yet demonstrate thread-count scaling.
The CLI build and complete unit suite pass with the optimized path enabled by default. The explicit fallback path also passes the Rspack core unit tests. Workspace-wide Clippy remains blocked by the existing rkyv 0.7/0.8 PortablePath mismatch; Clippy passes for rspack_core and rspack_benchmark.