Skip to content

test: verify CI behavior for conflicting PR #14776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JSerFeng wants to merge 1 commit into from
+1 −1
Closed

test: verify CI behavior for conflicting PR #14776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/rspack_plugin_esm_library/src/link.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ impl EsmLibraryPlugin {

// webpack require iterate the needed_namespace_objects and mutate `needed_namespace_objects`
// at the same time, https://github.com/webpack/webpack/blob/1f99ad6367f2b8a6ef17cce0e058f7a67fb7db18/lib/optimize/ConcatenatedModule.js#L1514
// Which is impossible in rust, using a fixed point algorithm to reach the same goal.
// Rust cannot mutate the collection while iterating, so repeat until no new module is found.
loop {
let mut changed = false;

Expand Down