feat: support caseSensitive in import.meta.glob#14811
Conversation
Deploying rspack with
|
| Latest commit: |
14bcc88
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://62779a90.rspack-v2.pages.dev |
| Branch Preview URL: | https://codex-import-meta-glob-case.rspack-v2.pages.dev |
📦 Binary Size-limit
❌ Size increased by 16.00KB from 66.59MB to 66.61MB (⬆️0.02%) |
Merging this PR will not alter performance
Comparing Footnotes
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14bcc88224
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Summary
import.meta.globsupport for thecaseSensitiveoptioncaseSensitive: falsefor case-insensitive positive and negative glob patternstruewhen the option is not a statically evaluated booleanExample
For example, this can match
./components/button.jseven though the pattern uses.JS. The returned key remains./components/button.js, preserving the filesystem spelling. Omitting the option keeps the existing case-sensitive behavior.The matching mode is included in context dependency and module identity so otherwise identical glob calls cannot incorrectly reuse modules across different case-sensitivity settings.
Related links
Validation
cargo fmt --all --checkcargo check -p rspack_core -p rspack_plugin_javascriptpnpm run build:binding:devpnpm run test:typecaseSensitivetest-content gapsChecklist
by OpenAI Codex