Commit 35bec58
committed
feat(core): bump default watch aggregateTimeout to 100ms; drop fixture overrides
rstest used to default rspack's `watchOptions.aggregateTimeout` to 5ms
(see Watching.ts comment). That was safe under the chokidar watcher
where the aggregate is just a watchpack-level event-merging window,
but is too aggressive under the rspack native watcher on macOS: the
runtime stats the changed file ~5ms after the FSEvent arrives, well
inside the vnode-cache settling window, and reads stale content. The
resulting "No test files need re-run" is the failure mode addressed by
this PR.
Set the default to 100ms in the rstest plugin so every watch project
inherits a sane value without each fixture wiring its own override.
Drop the per-fixture `tools.rspack.watchOptions.aggregateTimeout: 10`
that was added long ago (chokidar era). Individual cases that need a
different value can still set it via `tools.rspack.watchOptions` and
the user value wins through rsbuild's regular merge order.1 parent f1226f2 commit 35bec58
7 files changed
Lines changed: 12 additions & 44 deletions
File tree
- e2e
- watch
- fixtures-dynamic
- fixtures-setup
- fixtures-shortcuts
- fixtures
- packages/core
- src/core/plugins
- tests/core/__snapshots__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | 7 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | 9 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
61 | 67 | | |
62 | 68 | | |
63 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2256 | 2256 | | |
2257 | 2257 | | |
2258 | 2258 | | |
2259 | | - | |
| 2259 | + | |
2260 | 2260 | | |
2261 | 2261 | | |
2262 | 2262 | | |
| |||
0 commit comments