perf: use advanced serialization

Author: claneo

.github/workflows/test.yml

@@ -76,7 +76,7 @@ jobs:
       matrix:
         # run ut in macOS, as SWC cases will fail in Ubuntu CI
         os: [macos-14, windows-latest]
-        node_version: [18, 20, 22, 24]
+        node_version: [20, 22, 24]
 
     steps:
       - name: Checkout

packages/core/LICENSE.md

@@ -1159,7 +1159,7 @@ Licensed under MIT license in the repository at https://github.com/rspack-contri
 
 > MIT License
 >
-> Copyright (c) 2023-present ByteDance, Inc. and its affiliates.
+> Copyright (c) 2023-present Bytedance, Inc. and its affiliates.
 >
 > Permission is hereby granted, free of charge, to any person obtaining a copy
 > of this software and associated documentation files (the "Software"), to deal

packages/core/package.json

@@ -54,7 +54,7 @@
   "dependencies": {
     "@types/chai": "^5.2.3",
     "@rsbuild/core": "1.7.0-beta.0",
-    "tinypool": "^1.1.1"
+    "tinypool": "https://pkg.pr.new/tinypool@128"
   },
   "devDependencies": {
     "chai": "^5.3.3",

packages/core/src/core/listTests.ts

@@ -6,7 +6,7 @@ import type {
   ListCommandResult,
   Location,
   RstestContext,
-  Test,
+  TestInfo,
 } from '../types';
 import {
   bgColor,
@@ -230,7 +230,7 @@ export async function listTests(
     type: 'file' | 'suite' | 'case';
   }[] = [];
 
-  const traverseTests = (test: Test) => {
+  const traverseTests = (test: TestInfo) => {
     if (['skip', 'todo'].includes(test.runMode)) {
       return;
     }

packages/core/src/pool/forks.ts

@@ -1,6 +1,5 @@
 import EventEmitter from 'node:events';
 import { fileURLToPath } from 'node:url';
-import v8 from 'node:v8';
 import { createBirpc } from 'birpc';
 import { dirname, resolve } from 'pathe';
 import { type Options, Tinypool } from 'tinypool';
@@ -31,8 +30,6 @@ function createChannel(rpcMethods: RuntimeRPC) {
   };
 
   createBirpc<ServerRPC, RuntimeRPC>(rpcMethods, {
-    serialize: v8.serialize,
-    deserialize: (v) => v8.deserialize(Buffer.from(v)),
     post(v) {
       emitter.emit(events.message, v);
     },
@@ -78,6 +75,7 @@ export const createForksPool = (poolOptions: {
     minThreads,
     concurrentTasksPerWorker: 1,
     isolateWorkers: isolate,
+    serialization: 'advanced',
   };
 
   const pool = new Tinypool(options);

packages/core/src/pool/index.ts

@@ -8,19 +8,15 @@ import type {
   RstestContext,
   RuntimeConfig,
   RuntimeRPC,
-  Test,
   TestCaseInfo,
   TestFileInfo,
   TestFileResult,
+  TestInfo,
   TestResult,
   TestSuiteInfo,
   UserConsoleLog,
 } from '../types';
-import {
-  color,
-  needFlagExperimentalDetectModule,
-  serializableConfig,
-} from '../utils';
+import { color, needFlagExperimentalDetectModule } from '../utils';
 import { isMemorySufficient } from '../utils/memory';
 import { createForksPool } from './forks';
 
@@ -139,7 +135,7 @@ export const createPool = async ({
     project: ProjectContext;
   }) => Promise<
     {
-      tests: Test[];
+      tests: TestInfo[];
       testPath: string;
       errors?: FormattedError[];
       project: string;
@@ -295,7 +291,7 @@ export const createPool = async ({
                   project: projectName,
                   rootPath: context.rootPath,
                   projectRoot: project.rootPath,
-                  runtimeConfig: serializableConfig(runtimeConfig),
+                  runtimeConfig,
                 },
                 type: 'run',
                 setupEntries,
@@ -403,7 +399,7 @@ export const createPool = async ({
                   outputModule: project.outputModule,
                   rootPath: context.rootPath,
                   projectRoot: project.rootPath,
-                  runtimeConfig: serializableConfig(runtimeConfig),
+                  runtimeConfig,
                 },
                 type: 'collect',
                 setupEntries,

packages/core/src/runtime/api/index.ts

@@ -2,9 +2,9 @@ import type {
   Rstest,
   RstestExpect,
   RunnerHooks,
-  Test,
   TestCase,
   TestFileResult,
+  TestInfo,
   WorkerState,
 } from '../../types';
 import { createRunner } from '../runner';
@@ -20,7 +20,7 @@ export const createRstestRuntime = async (
       hooks: RunnerHooks,
       api: Rstest,
     ) => Promise<TestFileResult>;
-    collectTests: () => Promise<Test[]>;
+    collectTests: () => Promise<TestInfo[]>;
     getCurrentTest: () => TestCase | undefined;
   };
   api: Rstest;

packages/core/src/runtime/runner/index.ts

@@ -19,7 +19,7 @@ export function createRunner({ workerState }: { workerState: WorkerState }): {
       hooks: RunnerHooks,
       api: Rstest,
     ) => Promise<TestFileResult>;
-    collectTests: () => Promise<Test[]>;
+    collectTests: () => Promise<TestInfo[]>;
     getCurrentTest: TestRunner['getCurrentTest'];
   };
 } {
@@ -55,18 +55,7 @@ export function createRunner({ workerState }: { workerState: WorkerState }): {
         traverseUpdateTest(tests, testNamePattern);
         hooks.onTestFileReady?.({
           testPath,
-          tests: tests.map(function toTestInfo(test: Test): TestInfo {
-            return {
-              testId: test.testId,
-              name: test.name,
-              parentNames: test.parentNames,
-              testPath: test.testPath,
-              project: test.project,
-              type: test.type,
-              location: test.location,
-              tests: test.type === 'suite' ? test.tests.map(toTestInfo) : [],
-            };
-          }),
+          tests: tests.map(toTestInfo),
         });
         runtime.instance.updateStatus('running');
 
@@ -85,9 +74,23 @@ export function createRunner({ workerState }: { workerState: WorkerState }): {
         const tests = await runtime.instance.getTests();
         traverseUpdateTest(tests, testNamePattern);
 
-        return tests;
+        return tests.map(toTestInfo);
       },
       getCurrentTest: () => testRunner.getCurrentTest(),
     },
   };
 }
+
+function toTestInfo(test: Test): TestInfo {
+  return {
+    testId: test.testId,
+    name: test.name,
+    parentNames: test.parentNames,
+    testPath: test.testPath,
+    project: test.project,
+    type: test.type,
+    location: test.location,
+    tests: test.type === 'suite' ? test.tests.map(toTestInfo) : [],
+    runMode: test.runMode,
+  };
+}

packages/core/src/runtime/runner/runner.ts

@@ -300,6 +300,7 @@ export class TestRunner {
           testId: test.testId,
           type: 'suite',
           location: test.location,
+          runMode: test.runMode,
         });
 
         if (test.tests.length === 0) {
@@ -391,6 +392,7 @@ export class TestRunner {
           project: test.project,
           type: 'case',
           location: test.location,
+          runMode: test.runMode,
         });
 
         do {

packages/core/src/runtime/worker/index.ts

@@ -2,15 +2,16 @@ import type {
   MaybePromise,
   Rstest,
   RunWorkerOptions,
-  Test,
   TestFileResult,
+  TestInfo,
   WorkerState,
 } from '../../types';
 import './setup';
+import type { FileCoverageData } from 'istanbul-lib-coverage';
 import { install } from 'source-map-support';
 import { createCoverageProvider } from '../../coverage';
 import { globalApis } from '../../utils/constants';
-import { color, undoSerializableConfig } from '../../utils/helper';
+import { color } from '../../utils/helper';
 import { formatTestError, getRealTimers, setRealTimers } from '../util';
 import { createForksRpcOptions, createRuntimeRpc } from './rpc';
 import { RstestSnapshotEnvironment } from './snapshot';
@@ -57,7 +58,6 @@ const preparePool = async ({
   context,
 }: RunWorkerOptions['options']) => {
   setRealTimers();
-  context.runtimeConfig = undoSerializableConfig(context.runtimeConfig);
 
   // Prefer public env var from tinypool, fallback to context.taskId
   process.env.RSTEST_WORKER_ID = String(
@@ -259,7 +259,7 @@ const runInPool = async (
   options: RunWorkerOptions['options'],
 ): Promise<
   | {
-      tests: Test[];
+      tests: TestInfo[];
       testPath: string;
     }
   | TestFileResult
@@ -436,7 +436,12 @@ const runInPool = async (
       const coverageMap = coverageProvider.collect();
       if (coverageMap) {
         // Attach coverage data to test result
-        results.coverage = coverageMap.toJSON();
+        results.coverage = {};
+        Object.entries(coverageMap.toJSON()).forEach(([key, value]) => {
+          if ('toJSON' in value)
+            results.coverage![key] = value.toJSON() as FileCoverageData;
+          else results.coverage![key] = value;
+        });
       }
       // Cleanup
       coverageProvider.cleanup();