chore: enforce publint and arethetypeswrong on every package build (#1256)

fi3ework · web-flow · commit ee9d410acd5b · 2026-05-14T09:01:30.000Z
diff --git a/.gitignore b/.gitignore
@@ -32,6 +32,8 @@ test-temp-*
 .idea/
 .nx/
 .history/
+.claude/worktrees/
+.claude/settings.local.json
 .env.local
 .env.*.local
 
diff --git a/package.json b/package.json
@@ -35,6 +35,8 @@
     "playwright": "^1.60.0",
     "prettier": "^3.8.3",
     "prettier-plugin-packagejson": "^3.0.2",
+    "rsbuild-plugin-arethetypeswrong": "^0.3.1",
+    "rsbuild-plugin-publint": "^0.3.4",
     "typescript": "^6.0.3"
   },
   "packageManager": "pnpm@10.33.4",
diff --git a/packages/adapter-rsbuild/rslib.config.mts b/packages/adapter-rsbuild/rslib.config.mts
@@ -1,7 +1,9 @@
 import { defineConfig } from '@rslib/core';
+import { publishCheckPlugins } from '../../scripts/publishCheckPlugins';
 import { rsdoctorCIPlugin } from '../../scripts/rsdoctorPlugin';
 
 export default defineConfig({
+  plugins: publishCheckPlugins(),
   lib: [
     {
       format: 'esm',
diff --git a/packages/adapter-rslib/rslib.config.mts b/packages/adapter-rslib/rslib.config.mts
@@ -1,7 +1,9 @@
 import { defineConfig } from '@rslib/core';
+import { publishCheckPlugins } from '../../scripts/publishCheckPlugins';
 import { rsdoctorCIPlugin } from '../../scripts/rsdoctorPlugin';
 
 export default defineConfig({
+  plugins: publishCheckPlugins(),
   lib: [
     {
       format: 'esm',
diff --git a/packages/adapter-rspack/rslib.config.mts b/packages/adapter-rspack/rslib.config.mts
@@ -1,7 +1,9 @@
 import { defineConfig } from '@rslib/core';
+import { publishCheckPlugins } from '../../scripts/publishCheckPlugins';
 import { rsdoctorCIPlugin } from '../../scripts/rsdoctorPlugin';
 
 export default defineConfig({
+  plugins: publishCheckPlugins(),
   lib: [
     {
       format: 'esm',
diff --git a/packages/browser-react/rslib.config.ts b/packages/browser-react/rslib.config.ts
@@ -1,12 +1,19 @@
 import { defineConfig } from '@rslib/core';
+import { publishCheckPlugins } from '../../scripts/publishCheckPlugins';
 import { rsdoctorCIPlugin } from '../../scripts/rsdoctorPlugin';
 
 export default defineConfig({
+  plugins: publishCheckPlugins(),
   lib: [
     {
       format: 'esm',
       syntax: ['chrome 100'],
       dts: true,
+      redirect: {
+        // Append `.js` to relative imports in emitted .d.ts so they resolve
+        // under NodeNext/Node16 module resolution (ESM requires explicit ext).
+        dts: { extension: true },
+      },
       output: {
         target: 'web',
         sourceMap: process.env.SOURCEMAP === 'true',
diff --git a/packages/browser/package.json b/packages/browser/package.json
@@ -32,7 +32,7 @@
       "default": "./package.json"
     }
   },
-  "main": "./dist/index.js",
+  "main": "./dist/browser.js",
   "files": [
     "dist",
     "src",
diff --git a/packages/browser/rslib.config.ts b/packages/browser/rslib.config.ts
@@ -1,6 +1,7 @@
 import { createRequire } from 'node:module';
 import { defineConfig, rspack } from '@rslib/core';
 import { dirname, resolve } from 'pathe';
+import { publishCheckPlugins } from '../../scripts/publishCheckPlugins';
 import { rsdoctorCIPlugin } from '../../scripts/rsdoctorPlugin';
 
 const require = createRequire(import.meta.url);
@@ -10,6 +11,7 @@ const browserUiRoot = dirname(
 const browserUiDist = resolve(browserUiRoot, 'dist');
 
 export default defineConfig({
+  plugins: publishCheckPlugins(),
   lib: [
     {
       id: 'rstest-browser',
@@ -19,6 +21,11 @@ export default defineConfig({
         tsgo: true,
         bundle: false,
       },
+      redirect: {
+        // Append `.js` to relative imports in emitted .d.ts so they resolve
+        // under NodeNext/Node16 module resolution (ESM requires explicit ext).
+        dts: { extension: true },
+      },
       output: {
         externals: {
           // Keep @rstest/core as external
diff --git a/packages/core/rslib.config.ts b/packages/core/rslib.config.ts
@@ -1,5 +1,6 @@
 import { pluginNodePolyfill } from '@rsbuild/plugin-node-polyfill';
 import { defineConfig, rspack } from '@rslib/core';
+import { publishCheckPlugins } from '../../scripts/publishCheckPlugins';
 import { rsdoctorCIPlugin } from '../../scripts/rsdoctorPlugin';
 import { peerDependencies } from '../browser/package.json';
 import { licensePlugin } from './licensePlugin';
@@ -9,6 +10,7 @@ const isBuildWatch = process.argv.includes('--watch');
 const isLibBuild = process.argv.includes('build');
 
 export default defineConfig({
+  plugins: publishCheckPlugins(),
   lib: [
     {
       id: 'rstest',
diff --git a/packages/coverage-istanbul/rslib.config.ts b/packages/coverage-istanbul/rslib.config.ts
@@ -1,12 +1,19 @@
 import { defineConfig } from '@rslib/core';
+import { publishCheckPlugins } from '../../scripts/publishCheckPlugins';
 import { rsdoctorCIPlugin } from '../../scripts/rsdoctorPlugin';
 
 export default defineConfig({
+  plugins: publishCheckPlugins(),
   lib: [
     {
       format: 'esm',
       syntax: 'es2023',
       dts: true,
+      redirect: {
+        // Append `.js` to relative imports in emitted .d.ts so they resolve
+        // under NodeNext/Node16 module resolution (ESM requires explicit ext).
+        dts: { extension: true },
+      },
       output: {
         sourceMap: process.env.SOURCEMAP === 'true',
       },
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/scripts/publishCheckPlugins.ts b/scripts/publishCheckPlugins.ts
@@ -0,0 +1,23 @@
+import { pluginAreTheTypesWrong } from 'rsbuild-plugin-arethetypeswrong';
+import { pluginPublint } from 'rsbuild-plugin-publint';
+
+/**
+ * Shared `publint` + `arethetypeswrong` checks for every publishable
+ * package in this monorepo. Run after each Rslib build to catch publish
+ * issues before they ship.
+ *
+ * `ignoreResolutions: ['node10', 'node16-cjs']` is the attw CLI's
+ * `--profile esm-only` (see attw `packages/cli/src/profiles.ts`): every
+ * package here is ESM-only by design, so warnings about CJS consumers
+ * needing dynamic import are intentional, not bugs.
+ */
+export function publishCheckPlugins() {
+  return [
+    pluginPublint(),
+    pluginAreTheTypesWrong({
+      areTheTypesWrongOptions: {
+        ignoreResolutions: ['node10', 'node16-cjs'],
+      },
+    }),
+  ];
+}

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,9 @@`
`1`	`1`	`import { defineConfig } from '@rslib/core';`
	`2`	`+import { publishCheckPlugins } from '../../scripts/publishCheckPlugins';`
`2`	`3`	`import { rsdoctorCIPlugin } from '../../scripts/rsdoctorPlugin';`
`3`	`4`
`4`	`5`	`export default defineConfig({`
	`6`	`+ plugins: publishCheckPlugins(),`
`5`	`7`	`lib: [`
`6`	`8`	`{`
`7`	`9`	`format: 'esm',`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@`
`32`	`32`	`"default": "./package.json"`
`33`	`33`	`}`
`34`	`34`	`},`
`35`		`- "main": "./dist/index.js",`
	`35`	`+ "main": "./dist/browser.js",`
`36`	`36`	`"files": [`
`37`	`37`	`"dist",`
`38`	`38`	`"src",`