fix(core): pin pool worker node runtime to parent execPath#1088
Closed
omarshibli wants to merge 1 commit intoweb-infra-dev:mainfrom
Closed
fix(core): pin pool worker node runtime to parent execPath#1088omarshibli wants to merge 1 commit intoweb-infra-dev:mainfrom
omarshibli wants to merge 1 commit intoweb-infra-dev:mainfrom
Conversation
Member
Closing as obsolete. Happy to take a follow-up that adds an explicit |
Author
|
Thanks for the follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rstestworker pools did not explicitly pinexecPath, so worker runtime selection could drift based on environment/PATH resolution.That can cause parent/worker Node-version divergence and runtime-specific failures.
Root Cause
Both pool creation points relied on implicit process spawning defaults instead of forcing workers to use the parent process’ Node binary.
Fix
Set
execPath: process.execPathin both pool constructors:Files Changed
packages/core/src/pool/forks.tspackages/core/src/core/globalSetup.tspackages/core/tests/pool/forksExecPath.test.tspackages/core/tests/core/globalSetupExecPath.test.tsVerification
execPath: process.execPath.pnpm test packages/core/tests/pool/forksExecPath.test.ts packages/core/tests/core/globalSetupExecPath.test.ts2 passed, 0 failed.