Skip to content

ci: add knip for unused dependencies detection #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fi3ework merged 8 commits into from
Mar 25, 2026
Merged

ci: add knip for unused dependencies detection #1095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c54035d
ci: add knip for unused dependencies detection
fi3ework Mar 24, 2026
3c095f3
fix: ignore rstest.config.mts in knip to avoid build dependency in li…
fi3ework Mar 24, 2026
8126a21
fix: add build step in lint CI so knip can load rstest configs
fi3ework Mar 24, 2026
fe08b55
fix: restore @rstest/coverage-istanbul in root devDeps for e2e tests
fi3ework Mar 24, 2026
22140ec
fix: declare @rstest/coverage-istanbul in browser-coverage fixture
fi3ework Mar 24, 2026
2559116
fix: add @rstest/coverage-istanbul to e2e/reporter devDeps
fi3ework Mar 25, 2026
e15e708
chore: move @types/is-url to devDeps and document knip ignores
fi3ework Mar 25, 2026
3b0ed5f
fix: exclude knip.json from biome check to avoid JSON comment parse e…
fi3ework Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ jobs:
- name: Install Dependencies
run: pnpm install --ignore-scripts

- name: Build Packages
run: pnpm run build

- name: Lint
run: pnpm run lint

Expand All @@ -44,3 +47,6 @@ jobs:

- name: Check pnpm Dedupe
run: pnpm dedupe --check

- name: Check Unused Dependencies
run: pnpm run check-unused-deps
3 changes: 2 additions & 1 deletion .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
"singleQuote": true
"singleQuote": true,
"plugins": ["prettier-plugin-packagejson"]
}
3 changes: 2 additions & 1 deletion biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"!**/*.vue",
"!**/dist",
"!**/dist-types",
"!**/.vscode-test.mjs"
"!**/.vscode-test.mjs",
"!knip.json"
]
},
"formatter": {
Expand Down
9 changes: 9 additions & 0 deletions e2e/browser-mode/fixtures/browser-coverage/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"name": "@rstest/tests-browser-coverage",
"version": "1.0.0",
"private": true,
"devDependencies": {
"@rstest/core": "workspace:*",
"@rstest/coverage-istanbul": "workspace:*"
}
}
4 changes: 2 additions & 2 deletions e2e/build/fixtures/runtimeRequire/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"private": true,
"name": "@rstest/tests-runtime-require",
"version": "1.0.0"
"version": "1.0.0",
"private": true
}
6 changes: 3 additions & 3 deletions e2e/build/runtimeImport/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"name": "@rstest/tests-runtime-import",
"type": "module",
"version": "1.0.0"
"version": "1.0.0",
"private": true,
"type": "module"
}
2 changes: 1 addition & 1 deletion e2e/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@rstest/tests-cli",
"version": "1.0.0",
"private": true,
"devDependencies": {
"@rstest/core": "workspace:*"
}
Expand Down
2 changes: 1 addition & 1 deletion e2e/dom/fixtures/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"name": "@rstest/tests-env-jsdom",
"private": true,
"scripts": {
"dev": "rsbuild dev --open",
"build": "rsbuild build",
"dev": "rsbuild dev --open",
"preview": "rsbuild preview",
"test": "rstest run"
},
Expand Down
6 changes: 3 additions & 3 deletions e2e/externals/fixtures/test-bundle/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"name": "@rstest/tests-bundle",
"main": "index.ts",
"version": "1.0.0"
"version": "1.0.0",
"private": true,
"main": "index.ts"
}
6 changes: 3 additions & 3 deletions e2e/externals/fixtures/test-interop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"name": "@rstest/tests-interop",
"main": "index.js",
"version": "1.0.0"
"version": "1.0.0",
"private": true,
"main": "index.js"
}
6 changes: 3 additions & 3 deletions e2e/externals/fixtures/test-lodash/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"name": "@rstest/tests-lodash",
"main": "index.js",
"version": "1.0.0"
"version": "1.0.0",
"private": true,
"main": "index.js"
}
6 changes: 3 additions & 3 deletions e2e/externals/fixtures/test-module-field/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@rstest/tests-module-field",
"version": "1.0.0",
"private": true,
"main": "index.js",
"module": "index.es.js",
"version": "1.0.0"
"module": "index.es.js"
}
2 changes: 1 addition & 1 deletion e2e/externals/fixtures/test-pkg/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@rstest/tests-externals-fixtures",
"version": "1.0.0",
"private": true,
"devDependencies": {
"pathe": "^2.0.3"
}
Expand Down
2 changes: 1 addition & 1 deletion e2e/externals/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@rstest/tests-externals",
"version": "1.0.0",
"private": true,
"devDependencies": {
"@rstest/core": "workspace:*",
"picocolors": "^1.1.1",
Expand Down
2 changes: 1 addition & 1 deletion e2e/globals/fixtures/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@rstest/tests-global-fixtures",
"version": "1.0.0",
"private": true,
"devDependencies": {
"@rstest/core": "workspace:*",
"@rstest/tsconfig": "workspace:*"
Expand Down
2 changes: 1 addition & 1 deletion e2e/lifecycle/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@rstest/tests-life-cycle",
"version": "1.0.0",
"private": true,
"devDependencies": {
"@rstest/core": "workspace:*"
}
Expand Down
2 changes: 1 addition & 1 deletion e2e/mock/fixtures/reRexports/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@rstest/test-mock-re-exports",
"version": "1.0.0",
"private": true,
"devDependencies": {
"@rsbuild/plugin-react": "^1.4.6",
"@rstest/core": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion e2e/mock/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@rstest/test-mock",
"version": "1.0.0",
"private": true,
"devDependencies": {
"@rstest/core": "workspace:*",
"picocolors": "^1.1.1",
Expand Down
8 changes: 4 additions & 4 deletions e2e/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@rstest/tests",
"version": "1.0.0",
"private": true,
"scripts": {
"test": "rstest run",
"test:commonjs": "cross-env RSTEST_OUTPUT_MODULE=false rstest run",
Expand All @@ -20,11 +20,14 @@
"@testing-library/jest-dom": "^6.9.1",
"@testing-library/react": "^16.3.2",
"@testing-library/user-event": "^14.6.1",
"@types/fs-extra": "^11.0.4",
"@types/is-url": "^1.2.32",
"@types/jest-image-snapshot": "^6.4.1",
"@types/react": "^19.2.14",
"@types/react-dom": "^19.2.3",
"axios": "^1.13.6",
"cross-env": "^10.1.0",
"fs-extra": "^11.3.4",
"is-url": "^1.2.4",
"jest-image-snapshot": "^6.5.2",
"memfs": "^4.57.1",
Expand All @@ -36,8 +39,5 @@
"tinyexec": "^1.0.4",
"tree-kill": "^1.2.2",
"typescript": "^5.9.3"
},
"dependencies": {
"@types/is-url": "^1.2.32"
}
}
4 changes: 2 additions & 2 deletions e2e/projects/fixtures-shard/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"private": true,
"name": "@rstest/tests-projects-shard",
"sideEffects": true,
"version": "1.0.0",
"private": true,
"sideEffects": true,
"devDependencies": {
"@rstest/core": "workspace:*",
"@rstest/coverage-istanbul": "workspace:*"
Expand Down
4 changes: 2 additions & 2 deletions e2e/projects/fixtures-shard/packages/client-vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "@rstest/tests-project-shard-vue",
"private": true,
"version": "1.0.0",
"private": true,
"scripts": {
"dev": "rsbuild dev --open",
"build": "rsbuild build",
"dev": "rsbuild dev --open",
"preview": "rsbuild preview"
},
"dependencies": {
Expand Down
6 changes: 3 additions & 3 deletions e2e/projects/fixtures-shard/packages/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
"name": "@rstest/tests-project-shard-client",
"private": true,
"scripts": {
"dev": "rsbuild dev --open",
"build": "rsbuild build",
"test": "rstest run",
"preview": "rsbuild preview"
"dev": "rsbuild dev --open",
"preview": "rsbuild preview",
"test": "rstest run"
},
"dependencies": {
"react": "^19.2.4",
Expand Down
4 changes: 2 additions & 2 deletions e2e/projects/fixtures/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"private": true,
"name": "@rstest/tests-projects",
"sideEffects": true,
"version": "1.0.0",
"private": true,
"sideEffects": true,
"devDependencies": {
"@rstest/core": "workspace:*",
"@rstest/coverage-istanbul": "workspace:*"
Expand Down
4 changes: 2 additions & 2 deletions e2e/projects/fixtures/packages/client-vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "@rstest/tests-project-vue",
"private": true,
"version": "1.0.0",
"private": true,
"scripts": {
"dev": "rsbuild dev --open",
"build": "rsbuild build",
"dev": "rsbuild dev --open",
"preview": "rsbuild preview"
},
"dependencies": {
Expand Down
6 changes: 3 additions & 3 deletions e2e/projects/fixtures/packages/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
"name": "@rstest/tests-project-client",
"private": true,
"scripts": {
"dev": "rsbuild dev --open",
"build": "rsbuild build",
"test": "rstest run",
"preview": "rsbuild preview"
"dev": "rsbuild dev --open",
"preview": "rsbuild preview",
"test": "rstest run"
},
"dependencies": {
"react": "^19.2.4",
Expand Down
5 changes: 3 additions & 2 deletions e2e/reporter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
{
"private": true,
"name": "@rstest/tests-repoter",
"version": "1.0.0",
"private": true,
"devDependencies": {
"@rstest/core": "workspace:*"
"@rstest/core": "workspace:*",
"@rstest/coverage-istanbul": "workspace:*"
}
}
8 changes: 4 additions & 4 deletions e2e/runner/test/fixtures/test-rstest-globals/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"private": true,
"name": "@rstest/tests-rstest-globals",
"main": "index.js",
"type": "module",
"sideEffects": true,
"version": "1.0.0",
"private": true,
"sideEffects": true,
"type": "module",
"main": "index.js",
"devDependencies": {
"@rstest/core": "workspace:*"
}
Expand Down
8 changes: 4 additions & 4 deletions e2e/runner/test/fixtures/test-rstest-import/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"private": true,
"name": "@rstest/tests-rstest-import",
"main": "index.js",
"type": "module",
"sideEffects": true,
"version": "1.0.0",
"private": true,
"sideEffects": true,
"type": "module",
"main": "index.js",
"devDependencies": {
"@rstest/core": "workspace:*"
}
Expand Down
6 changes: 3 additions & 3 deletions e2e/setup/fixtures/package-name/test-setup-esm-fixtures/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"private": true,
"name": "@rstest/tests-setup-esm",
"version": "1.0.0",
"private": true,
"exports": {
".": {
"import": "./index.js"
}
},
"version": "1.0.0"
}
}
6 changes: 3 additions & 3 deletions e2e/setup/fixtures/package-name/test-setup-fixtures/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"name": "@rstest/tests-setup",
"main": "index.js",
"version": "1.0.0"
"version": "1.0.0",
"private": true,
"main": "index.js"
}
2 changes: 1 addition & 1 deletion e2e/ssr/fixtures/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@rstest/tests-ssr",
"version": "1.0.0",
"private": true,
"dependencies": {
"react": "^19.2.4",
"react-dom": "^19.2.4"
Expand Down
4 changes: 2 additions & 2 deletions e2e/test-coverage/fixtures/allow-external/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"private": true,
"name": "@rstest/tests-allow-external",
"type": "module",
"version": "1.0.0",
"private": true,
"type": "module",
"devDependencies": {
"@rstest/core": "workspace:*",
"@rstest/coverage-istanbul": "workspace:*"
Expand Down
8 changes: 4 additions & 4 deletions e2e/test-coverage/fixtures/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"private": true,
"name": "@rstest/tests-coverage",
"main": "index.js",
"type": "module",
"sideEffects": true,
"version": "1.0.0",
"private": true,
"sideEffects": true,
"type": "module",
"main": "index.js",
"devDependencies": {
"@rstest/core": "workspace:*",
"@rstest/coverage-istanbul": "workspace:*"
Expand Down
4 changes: 2 additions & 2 deletions e2e/vue/fixtures/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "@rstest/tests-vue",
"private": true,
"version": "1.0.0",
"private": true,
"scripts": {
"dev": "rsbuild dev --open",
"build": "rsbuild build",
"dev": "rsbuild dev --open",
"preview": "rsbuild preview"
},
"dependencies": {
Expand Down
Loading
Loading