Skip to content

fix(browser): keep lazyCompilation and hmr enabled #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9aoy merged 2 commits into from
Mar 26, 2026
Merged

fix(browser): keep lazyCompilation and hmr enabled #1109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fd80bf
fix(browser): disable lazyCompilation in non-watch runs
fi3ework Mar 26, 2026
9b2dd3c
fix(browser): keep lazyCompilation and hmr enabled
fi3ework Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/browser/src/hostController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,12 +542,12 @@ export const createBrowserLazyCompilationConfig = (
};
};

export const createBrowserRsbuildDevConfig = (isWatchMode: boolean) => {
export const createBrowserRsbuildDevConfig = (_isWatchMode: boolean) => {
return {
writeToDisk: isDebug(),
// Disable HMR in non-watch mode (tests run once and exit).
// Aligns with node mode behavior (packages/core/src/core/rsbuild.ts).
hmr: isWatchMode,
// Keep HMR enabled in browser mode even for one-shot runs.
// lazyCompilation depends on HMR runtime wiring for async import chains.
hmr: true,
client: {
logLevel: 'error' as const,
},
Expand Down
4 changes: 2 additions & 2 deletions packages/browser/tests/hostController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,10 @@ describe('browser config resolution', () => {
expect(browserConfig.strictPort).toBe(true);
});

it('should disable HMR in non-watch mode and keep error-only client log', () => {
it('should enable HMR in non-watch mode and keep error-only client log', () => {
const devConfig = createBrowserRsbuildDevConfig(false);

expect(devConfig.hmr).toBe(false);
expect(devConfig.hmr).toBe(true);
expect(devConfig.client.logLevel).toBe('error');
});

Expand Down
Loading