Skip to content

docs(core): fix coverage exclude JSDoc defaults#1125

Merged
9aoy merged 1 commit into
mainfrom
fix/coverage-exclude-jsdoc
Apr 1, 2026
Merged

docs(core): fix coverage exclude JSDoc defaults#1125
9aoy merged 1 commit into
mainfrom
fix/coverage-exclude-jsdoc

Conversation

@9aoy

@9aoy 9aoy commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

Background

The default coverage.exclude patterns in the core type JSDoc had drifted from the actual runtime defaults after #1022. That made the inline API documentation show dist/** as excluded by default even though the current behavior no longer does that.

Implementation

  • Updated the CoverageOptions.exclude JSDoc in packages/core/src/types/coverage.ts to match the real default patterns.
  • Removed the stale dist/** entry and listed the current spec and declaration file patterns explicitly.
  • Validation: ran pnpm prettier --check packages/core/src/types/coverage.ts; skipped broader build and test runs because this is a JSDoc-only change.

User Impact

Developers reading the core config types now see the correct default coverage.exclude behavior.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

Rsdoctor Bundle Diff Analysis

Found 12 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
adapter-rsbuild 2.1 KB 0
adapter-rslib 23.1 KB 0
adapter-rspack 5.9 KB 0
browser 2.0 MB 0
browser-react 3.7 KB 0
browser-ui 804.4 KB 0
coverage-istanbul 8.9 KB 0
core/browser 970.4 KB 0
core/loaders 869.0 B 0
core/main 1.5 MB 0
vscode/extension 60.2 MB 0
vscode/worker 14.4 KB 0

Generated by Rsdoctor GitHub Action

@9aoy 9aoy merged commit 15c15bb into main Apr 1, 2026
19 checks passed
@9aoy 9aoy deleted the fix/coverage-exclude-jsdoc branch April 1, 2026 08:02
@9aoy 9aoy mentioned this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Dist is not excluded from coverage by default

1 participant