Skip to content

chore: clear existing lint warnings#1204

Merged
fi3ework merged 2 commits into
mainfrom
fix/lint-warnings
Apr 24, 2026
Merged

chore: clear existing lint warnings#1204
fi3ework merged 2 commits into
mainfrom
fix/lint-warnings

Conversation

@9aoy

@9aoy 9aoy commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Background

Biome reported existing warnings in the core mock runtime, a watch e2e fixture string, and the Svelte example component, which kept the repository from a clean lint run.

Implementation

  • Removed the unused isEsModule variable from the core mock runtime.
  • Added targeted Biome suppressions for the watch fixture source string and the Svelte template-backed script variables.

User Impact

pnpm lint now completes without warning noise from these known cases.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@9aoy 9aoy changed the title fix: clear existing lint warnings chore: clear existing lint warnings Apr 24, 2026
@github-actions

github-actions Bot commented Apr 24, 2026

Copy link
Copy Markdown

Rsdoctor Bundle Diff Analysis

Found 12 projects in monorepo, 1 project with changes.

📊 Quick Summary
Project Total Size Change
adapter-rsbuild 2.2 KB 0
adapter-rslib 23.2 KB 0
adapter-rspack 5.9 KB 0
browser 2.0 MB 0
browser-react 3.7 KB 0
browser-ui 802.9 KB 0
coverage-istanbul 9.6 KB 0
core/browser 966.1 KB 0
core/loaders 869.0 B 0
core/main 1.6 MB -39.0 B (-0.0%)
vscode/extension 60.3 MB 0
vscode/worker 14.4 KB 0
📋 Detailed Reports (Click to expand)

📁 core/main

Path: packages/core/.rsdoctor/main/rsdoctor-data.json

📌 Baseline Commit: 4a86b205b6 | PR: #1203

Metric Current Baseline Change
📊 Total Size 1.6 MB 1.6 MB -39.0 B (-0.0%)
📄 JavaScript 1.5 MB 1.5 MB -39.0 B (-0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 79.2 KB 79.2 KB 0

📦 Download Diff Report: core/main Bundle Diff

Generated by Rsdoctor GitHub Action

@codspeed-hq

codspeed-hq Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 1 untouched benchmark
⏩ 3 skipped benchmarks1


Comparing fix/lint-warnings (39f2fc8) with main (4a86b20)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Switch `pnpm lint` from `--diagnostic-level=warn` (display-only) to
`--error-on-warnings` so future biome warnings fail CI instead of
accumulating until someone sweeps them manually.

Co-authored-by: 9aoy <9aoyuao@gmail.com>
Co-authored-by: fi3ework <fi3ework@gmail.com>
@fi3ework fi3ework enabled auto-merge (squash) April 24, 2026 06:28
@fi3ework fi3ework merged commit 1494fd3 into main Apr 24, 2026
20 checks passed
@fi3ework fi3ework deleted the fix/lint-warnings branch April 24, 2026 06:39
@fi3ework fi3ework mentioned this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants