fix(core): guard interop has trap against primitive default export#1234
Merged
Conversation
The `has` trap in `createInteropProxy` evaluated `prop in defaultExport` behind only a truthiness check. For CJS modules whose `module.exports` is a truthy primitive (`42`, `"str"`, `true`), this threw `TypeError: Cannot use 'in' operator to search for ... in 42`. Mirror the `get` trap's optional-chaining semantics by gating with `!isPrimitive(defaultExport)`.
Rsdoctor Bundle Diff AnalysisFound 12 projects in monorepo, 1 project with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 core/mainPath:
📦 Download Diff Report: core/main Bundle Diff Generated by Rsdoctor GitHub Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bug_004).hastrap increateInteropProxyevaluatedprop in defaultExportbehind only a truthiness check. For CJS modules whosemodule.exportsis a truthy primitive (42,"str",true),inagainst a primitive throwsTypeError: Cannot use 'in' operator to search for ... in 42.gettrap was already safe via?.optional chaining; thehaspath needed an explicit!isPrimitive(defaultExport)gate to match.Test plan
pnpm --filter @rstest/core test -- tests/runner/interop.test.ts(189/189 pass, including newprimitive module.exportsregression cases for'foo' in nsnot throwing anddefaultresolving via bothgetandhas).