Skip to content

chore(deps): update pnpm workspace settings#1241

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore/update-pnpm-workspace-settings
May 12, 2026
Merged

chore(deps): update pnpm workspace settings#1241
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore/update-pnpm-workspace-settings

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

Background

pnpm 10.33.4 supports workspace-level build-script and release-age controls, which keeps dependency manager policy out of the root package manifest and lets Renovate manage pnpm updates.

Implementation

  • Pins the project package manager to pnpm 10.33.4 and removes pnpm from Renovate's ignored dependencies.
  • Moves existing package extensions into pnpm-workspace.yaml and adds explicit allowBuilds, strictDepBuilds, and minimumReleaseAge settings.

User Impact

None - dependency installation policy is tightened without changing Rstest runtime APIs.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings May 12, 2026 03:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Moves pnpm policy/configuration from package.json into pnpm-workspace.yaml while pinning the repo to pnpm 10.33.4, so Renovate can manage pnpm updates and workspace-level install policy can be enforced centrally.

Changes:

  • Pin packageManager to pnpm@10.33.4 and stop ignoring pnpm in Renovate.
  • Add workspace-level pnpm controls (allowBuilds, strictDepBuilds, minimumReleaseAge) and migrate packageExtensions into pnpm-workspace.yaml.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
pnpm-workspace.yaml Adds workspace-level build/release-age policies and moves packageExtensions here.
package.json Pins package manager version and removes pnpm config block now managed at workspace level.
.github/renovate.json5 Allows Renovate to update pnpm by removing it from ignored deps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment thread pnpm-workspace.yaml
Comment thread pnpm-workspace.yaml
@github-actions

Copy link
Copy Markdown

Rsdoctor Bundle Diff Analysis

Found 12 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
adapter-rsbuild 3.6 KB 0
adapter-rslib 24.6 KB 0
adapter-rspack 7.7 KB 0
browser 2.0 MB 0
browser-react 3.7 KB 0
browser-ui 803.5 KB 0
coverage-istanbul 9.6 KB 0
core/browser 970.2 KB 0
core/loaders 869.0 B 0
core/main 1.6 MB 0
vscode/extension 58.9 MB 0
vscode/worker 14.4 KB 0

Generated by Rsdoctor GitHub Action

@chenjiahan chenjiahan requested review from 9aoy and fi3ework May 12, 2026 05:44
@chenjiahan chenjiahan merged commit 9a875bd into main May 12, 2026
23 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/chore/update-pnpm-workspace-settings branch May 12, 2026 05:59
@9aoy 9aoy mentioned this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants