feat(core): auto install missing runtime dependencies#1252
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Rsdoctor Bundle Diff AnalysisFound 12 projects in monorepo, 1 project with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 core/mainPath:
📦 Download Diff Report: core/main Bundle Diff Generated by Rsdoctor GitHub Action |
…tion or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98352d19d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fi3ework
left a comment
fi3ework
left a comment
There was a problem hiding this comment.
Bare-name install resolves to latest. Since @rstest/core and @rstest/coverage-istanbul version independently with a workspace:~ peer, latest may pull a provider that doesn't satisfy the installed core's peer range. Aligning the two packages to the same version with a workspace:* peer would make auto-installing latest always safe.
This is a change in release strategy; perhaps we can keep all packages in the current repository on the same version.
Deploying rstest with
|
| Latest commit: |
5b9b2fb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://96feb207.rstest.pages.dev |
| Branch Preview URL: | https://9aoy-auto-install-missing-de.rstest.pages.dev |
2 participants
Summary
Background
Missing optional runtime packages can fail late when coverage providers or DOM test environments are loaded from worker or merge paths.
Implementation
@rstest/coverage-istanbul,jsdom, andhappy-domwithout pinning them to the Rstest version.coverage/install.tssocoverage/index.tsonly resolves and loads providers.User Impact
Users can accept an interactive prompt to install missing coverage or DOM environment packages before tests run.
Related Links
None
Checklist