Skip to content

fix(core): normalize mixed pool CLI options#1290

Open
9aoy wants to merge 1 commit into
mainfrom
9aoy/fix-pool-cli-max-workers
Open

fix(core): normalize mixed pool CLI options#1290
9aoy wants to merge 1 commit into
mainfrom
9aoy/fix-pool-cli-max-workers

Conversation

@9aoy
Copy link
Copy Markdown
Collaborator

@9aoy 9aoy commented May 20, 2026

Summary

This PR fixes rstest --pool forks --pool.maxWorkers 1, which previously failed during CLI parsing because --pool set pool to a string before --pool.maxWorkers tried to write a nested property. The CLI now normalizes mixed pool shorthand and nested pool options to --pool.type before handing args to cac, matching the existing mixed coverage option behavior.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions
Copy link
Copy Markdown

Rsdoctor Bundle Diff Analysis

Found 12 projects in monorepo, 1 project with changes.

📊 Quick Summary
Project Total Size Change
adapter-rsbuild 3.7 KB 0
adapter-rslib 24.7 KB 0
adapter-rspack 7.8 KB 0
browser 2.0 MB 0
browser-react 3.7 KB 0
browser-ui 810.6 KB 0
coverage-istanbul 9.6 KB 0
core/browser 970.1 KB 0
core/loaders 869.0 B 0
core/main 1.7 MB +419.0 B (0.0%)
vscode/extension 26.9 MB 0
vscode/worker 14.4 KB 0
📋 Detailed Reports (Click to expand)

📁 core/main

Path: packages/core/.rsdoctor/main/rsdoctor-data.json

📌 Baseline Commit: 7938535556 | PR: #1286

Metric Current Baseline Change
📊 Total Size 1.7 MB 1.7 MB +419.0 B (0.0%)
📄 JavaScript 1.6 MB 1.6 MB +419.0 B (0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 81.6 KB 81.6 KB 0

📦 Download Diff Report: core/main Bundle Diff

Generated by Rsdoctor GitHub Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant